Gnus development mailing list
 help / color / mirror / Atom feed
From: Jan Vroonhof <vroonhof@math.ethz.ch>
Subject: Re: major problem with recent cvs
Date: 16 Mar 2000 12:40:00 +0100	[thread overview]
Message-ID: <byd7ovgn3j.fsf@bolzano.math.ethz.ch> (raw)
In-Reply-To: Per Abrahamsen's message of "Thu, 16 Mar 2000 10:36:02 GMT"


Per Abrahamsen <abraham@dina.kvl.dk> writes:

> intentional, and the old semantics made perfectly sense), checked that
> it worked, saw that Simon Josefsson had came up with the exact same
> solution, and that you had some completely different untested changes
> in files unrelated to the place in the code that was changed.

I'm using the changes for a few days now. They are tested.

Requiring the paths to end in a separator is fragile. Note that the
changes I made are not unrelated, they are simply the functions that
use the functions that cause the problem.

> Given this, commiting my (and Simons) changes seemed like the safest
> course af action.

It sure is the shortest change. However I claim my version is more
robust against future changes. Using concat to construct paths is
wrong. Maybe because this is 5.8.x using the minimal change is good,
but I propose doing my change in any new development branch at least.

Jan



  reply	other threads:[~2000-03-16 11:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-03-13 16:54 Laura Conrad
2000-03-13 23:58 ` Simon Josefsson
2000-03-14 10:48   ` Kai Großjohann
2000-03-14 11:42     ` Simon Josefsson
2000-03-14 14:56       ` lconrad
2000-03-14 15:07         ` Karl Kleinpaste
2000-03-14 15:37           ` Laura Conrad
2000-03-14 15:59         ` Kai Großjohann
2000-03-14 16:18           ` Laura Conrad
2000-03-14 16:55           ` Gunnar Evermann
2000-03-14 16:57             ` Kai Großjohann
2000-03-14 16:47         ` Kai Großjohann
2000-03-14 20:18           ` lconrad
2000-03-17 17:12         ` Resolution (was: Re: major problem with recent cvs) lconrad
2000-03-15 10:43       ` major problem with recent cvs Per Abrahamsen
2000-03-15 18:07         ` Jan Vroonhof
2000-03-16 10:34           ` Per Abrahamsen
2000-03-16 11:40             ` Jan Vroonhof [this message]
2000-03-17 13:20               ` Per Abrahamsen
2000-03-14 16:43   ` Jan Vroonhof
2000-03-14 17:17   ` Jan Vroonhof
     [not found] <8aj6qv$qvc$1@quimby.gnus.org>
2000-03-13 20:48 ` Emerick Rogul
2000-03-14 17:35   ` Matt Swift

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=byd7ovgn3j.fsf@bolzano.math.ethz.ch \
    --to=vroonhof@math.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).