From: Jan Vroonhof <vroonhof@math.ethz.ch>
Cc: ding@ifi.uio.no
Subject: Re: Smileys again...
Date: 17 Jul 1996 15:55:51 +0200 [thread overview]
Message-ID: <byenmb6l20.fsf@math.ethz.ch> (raw)
In-Reply-To: Danny Siu's message of 16 Jul 1996 15:08:06 -0700
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 4782 bytes --]
Danny Siu <dsiu@mv.us.adobe.com> writes:
> Jan> The following fixes the too aggressive matching of "://" in 5.2.35
> Jan> and adds some more mild regexps such that you can read Tom
> Jan> Cristiansen's messsages.
>
> The patch looks good except the :// regexp matches also http://blahblah...
> A smiley in a URL is incorrect at all....
d*mn, that was exactly the main problem I was trying to fix. Here is
the right version of the patch (against 5.2.36):
*** ChangeLog.orig Tue Jul 16 22:20:15 1996
--- ChangeLog Wed Jul 17 15:46:29 1996
***************
*** 1,3 ****
--- 1,8 ----
+ Wed Jul 17 15:44:51 1996 Jan Vroonhof <vroonhof@math.ethz.ch (Jan Vroonhof)>
+
+ * smiley.el (smiley-deformed-regexp-alist): Fix for matching
+ 'http://' had the wrong slashes.
+
Tue Jul 16 20:05:49 1996 Lars Magne Ingebrigtsen <larsi@hler.ifi.uio.no>
* message.el (message-send-mail): Bugged out under Emacs.
***************
*** 9,14 ****
--- 14,24 ----
Sun Jul 14 20:01:26 1996 Lars Magne Ingebrigtsen <larsi@ifi.uio.no>
* gnus.el: Gnus v5.2.35 is released.
+
+ Mon Jul 15 18:11:13 1996 Jan Vroonhof <vroonhof@math.ethz.ch (Jan Vroonhof)>
+
+ * smiley.el (smiley-regexp-alist): Don't match important parts of URLs
+ (smiley-nosey-regexp-alist): New variable.
Sun Jul 14 18:21:14 1996 Lars Magne Ingebrigtsen <larsi@ifi.uio.no>
*** smiley.el.orig Sun Jul 14 18:40:45 1996
--- smiley.el Wed Jul 17 15:45:09 1996
***************
*** 42,53 ****
(defvar smiley-data-directory (message-xmas-find-glyph-directory "smilies")
"Location of the smiley faces files.")
! (defvar smiley-regexp-alist
'(("\\(:-*[<«]+\\)\\W" 1 "FaceAngry.xpm")
("\\(:-+\\]+\\)\\W" 1 "FaceGoofy.xpm")
("\\(:-*D\\)\\W" 1 "FaceGrinning.xpm")
("\\(:-*[)>}»]+\\)\\W" 1 "FaceHappy.xpm")
! ("\\(:-*[/\\\"]+\\)\\W" 1 "FaceIronic.xpm")
("\\([8|]-*[|Oo%]\\)\\W" 1 "FaceKOed.xpm")
("\\([:|]-*#+\\)\\W" 1 "FaceNyah.xpm")
("\\(:-*[({]+\\)\\W" 1 "FaceSad.xpm")
--- 42,55 ----
(defvar smiley-data-directory (message-xmas-find-glyph-directory "smilies")
"Location of the smiley faces files.")
! ;; Notice the subtle differences in the regular expessions in the two alists below
!
! (defvar smiley-deformed-regexp-alist
'(("\\(:-*[<«]+\\)\\W" 1 "FaceAngry.xpm")
("\\(:-+\\]+\\)\\W" 1 "FaceGoofy.xpm")
("\\(:-*D\\)\\W" 1 "FaceGrinning.xpm")
("\\(:-*[)>}»]+\\)\\W" 1 "FaceHappy.xpm")
! ("\\(:-*[/\\\"]\\)[^//]" 1 "FaceIronic.xpm")
("\\([8|]-*[|Oo%]\\)\\W" 1 "FaceKOed.xpm")
("\\([:|]-*#+\\)\\W" 1 "FaceNyah.xpm")
("\\(:-*[({]+\\)\\W" 1 "FaceSad.xpm")
***************
*** 58,64 ****
("\\(;-*[>)}»]+\\)\\W" 1 "FaceWinking.xpm")
("\\(:-*[Vvµ]\\)\\W" 1 "FaceWry.xpm")
("\\([:|]-*P\\)\\W" 1 "FaceYukky.xpm"))
! "A list of regexps to map smilies to real images.")
(defvar smiley-flesh-color "yellow"
"Flesh color.")
--- 60,91 ----
("\\(;-*[>)}»]+\\)\\W" 1 "FaceWinking.xpm")
("\\(:-*[Vvµ]\\)\\W" 1 "FaceWry.xpm")
("\\([:|]-*P\\)\\W" 1 "FaceYukky.xpm"))
! "Normal and deformed faces for smilies.")
!
! (defvar smiley-nosey-regexp-alist
! '(("\\(:-+[<«]+\\)\\W" 1 "FaceAngry.xpm")
! ("\\(:-+\\]+\\)\\W" 1 "FaceGoofy.xpm")
! ("\\(:-+D\\)\\W" 1 "FaceGrinning.xpm")
! ("\\(:-+[}»]+\\)\\W" 1 "FaceHappy.xpm")
! ("\\(:-*)+\\)\\W" 1 "FaceHappy.xpm") ;; The exception that confirms the rule
! ("\\(:-+[/\\\"]+\\)\\W" 1 "FaceIronic.xpm")
! ("\\([8|]-+[|Oo%]\\)\\W" 1 "FaceKOed.xpm")
! ("\\([:|]-+#+\\)\\W" 1 "FaceNyah.xpm")
! ("\\(:-+[({]+\\)\\W" 1 "FaceSad.xpm")
! ("\\(:-+[Oo\*]\\)\\W" 1 "FaceStartled.xpm")
! ("\\(:-+|\\)\\W" 1 "FaceStraight.xpm")
! ("\\(:-+p\\)\\W" 1 "FaceTalking.xpm")
! ("\\(:-+d\\)\\W" 1 "FaceTasty.xpm")
! ("\\(;-+[>)}»]+\\)\\W" 1 "FaceWinking.xpm")
! ("\\(:-+[Vvµ]\\)\\W" 1 "FaceWry.xpm")
! ("\\([:|]-+P\\)\\W" 1 "FaceYukky.xpm"))
! "Smileys with noses. These get less false matches.")
!
! (defvar smiley-regexp-alist smiley-deformed-regexp-alist
! "A list of regexps to map smilies to real images.
! Defaults to the content of smiley-deformed-regexp-alist.
! An alternative smiley-nose-regexp-alist that
! matches less aggresively is available.")
(defvar smiley-flesh-color "yellow"
"Flesh color.")
Greetings,
Jan
P.S. Should the "nosey" verion match ":)" it still gives some false
matches, but a quick look in rec.humor showed that it is used a lot.
--
Jan Vroonhof http://www.math.ethz.ch/~vroonhof/
Mathematik, vroonhof@math.ethz.ch
HG E16, ETH-Zentrum, Tel: +41-1-6325456/25154
Raemistrasse 101, CH-8092 Zuerich. Fax: +41-1-6321085
next prev parent reply other threads:[~1996-07-17 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
1996-07-14 18:01 Gnus v5.2.35 is released Lars Magne Ingebrigtsen
1996-07-15 17:35 ` Smileys again Jan Vroonhof
1996-07-16 22:08 ` Danny Siu
1996-07-17 13:55 ` Jan Vroonhof [this message]
1996-07-16 18:15 ` Gnus v5.2.35 is released Mark Eichin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=byenmb6l20.fsf@math.ethz.ch \
--to=vroonhof@math.ethz.ch \
--cc=ding@ifi.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).