From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/7222 Path: main.gmane.org!not-for-mail From: Jan Vroonhof Newsgroups: gmane.emacs.gnus.general Subject: Re: Smileys again... Date: 17 Jul 1996 15:55:51 +0200 Sender: vroonhof@math.ethz.ch Message-ID: References: NNTP-Posting-Host: coloc-standby.netfonds.no X-Trace: main.gmane.org 1035147561 6311 80.91.224.250 (20 Oct 2002 20:59:21 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 20 Oct 2002 20:59:21 +0000 (UTC) Cc: ding@ifi.uio.no Return-Path: ding-request@ifi.uio.no Original-Received: from ifi.uio.no (ifi.uio.no [129.240.64.2]) by deanna.miranova.com (8.7.5/8.6.9) with SMTP id HAA08550 for ; Wed, 17 Jul 1996 07:21:59 -0700 Original-Received: from frege.math.ethz.ch (root@frege-math-bb.math.ethz.ch [129.132.148.14]) by ifi.uio.no with ESMTP (8.6.11/ifi2.4) id ; Wed, 17 Jul 1996 15:56:28 +0200 Original-Received: from fresnel.math.ethz.ch (vroonhof@fresnel-d-math-south-g-servers.math.ethz.ch [129.132.145.6]) by frege.math.ethz.ch (8.6.4/Main-mathdept-mailer) with ESMTP id PAA14839; Wed, 17 Jul 1996 15:56:26 +0200 Original-Received: (vroonhof@localhost) by fresnel.math.ethz.ch (8.6.9/D-MATH-client) id PAA19105; Wed, 17 Jul 1996 15:55:52 +0200 Original-To: Danny Siu Original-CC: larsi@ifi.uio.no In-Reply-To: Danny Siu's message of 16 Jul 1996 15:08:06 -0700 Original-Lines: 129 X-Mailer: Gnus v5.2.36/XEmacs 19.14 Xref: main.gmane.org gmane.emacs.gnus.general:7222 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:7222 Danny Siu writes: > Jan> The following fixes the too aggressive matching of "://" in 5.2.35 > Jan> and adds some more mild regexps such that you can read Tom > Jan> Cristiansen's messsages. > > The patch looks good except the :// regexp matches also http://blahblah... > A smiley in a URL is incorrect at all.... d*mn, that was exactly the main problem I was trying to fix. Here is the right version of the patch (against 5.2.36): *** ChangeLog.orig Tue Jul 16 22:20:15 1996 --- ChangeLog Wed Jul 17 15:46:29 1996 *************** *** 1,3 **** --- 1,8 ---- + Wed Jul 17 15:44:51 1996 Jan Vroonhof + + * smiley.el (smiley-deformed-regexp-alist): Fix for matching + 'http://' had the wrong slashes. + Tue Jul 16 20:05:49 1996 Lars Magne Ingebrigtsen * message.el (message-send-mail): Bugged out under Emacs. *************** *** 9,14 **** --- 14,24 ---- Sun Jul 14 20:01:26 1996 Lars Magne Ingebrigtsen * gnus.el: Gnus v5.2.35 is released. + + Mon Jul 15 18:11:13 1996 Jan Vroonhof + + * smiley.el (smiley-regexp-alist): Don't match important parts of URLs + (smiley-nosey-regexp-alist): New variable. Sun Jul 14 18:21:14 1996 Lars Magne Ingebrigtsen *** smiley.el.orig Sun Jul 14 18:40:45 1996 --- smiley.el Wed Jul 17 15:45:09 1996 *************** *** 42,53 **** (defvar smiley-data-directory (message-xmas-find-glyph-directory "smilies") "Location of the smiley faces files.") ! (defvar smiley-regexp-alist '(("\\(:-*[<«]+\\)\\W" 1 "FaceAngry.xpm") ("\\(:-+\\]+\\)\\W" 1 "FaceGoofy.xpm") ("\\(:-*D\\)\\W" 1 "FaceGrinning.xpm") ("\\(:-*[)>}»]+\\)\\W" 1 "FaceHappy.xpm") ! ("\\(:-*[/\\\"]+\\)\\W" 1 "FaceIronic.xpm") ("\\([8|]-*[|Oo%]\\)\\W" 1 "FaceKOed.xpm") ("\\([:|]-*#+\\)\\W" 1 "FaceNyah.xpm") ("\\(:-*[({]+\\)\\W" 1 "FaceSad.xpm") --- 42,55 ---- (defvar smiley-data-directory (message-xmas-find-glyph-directory "smilies") "Location of the smiley faces files.") ! ;; Notice the subtle differences in the regular expessions in the two alists below ! ! (defvar smiley-deformed-regexp-alist '(("\\(:-*[<«]+\\)\\W" 1 "FaceAngry.xpm") ("\\(:-+\\]+\\)\\W" 1 "FaceGoofy.xpm") ("\\(:-*D\\)\\W" 1 "FaceGrinning.xpm") ("\\(:-*[)>}»]+\\)\\W" 1 "FaceHappy.xpm") ! ("\\(:-*[/\\\"]\\)[^//]" 1 "FaceIronic.xpm") ("\\([8|]-*[|Oo%]\\)\\W" 1 "FaceKOed.xpm") ("\\([:|]-*#+\\)\\W" 1 "FaceNyah.xpm") ("\\(:-*[({]+\\)\\W" 1 "FaceSad.xpm") *************** *** 58,64 **** ("\\(;-*[>)}»]+\\)\\W" 1 "FaceWinking.xpm") ("\\(:-*[Vvµ]\\)\\W" 1 "FaceWry.xpm") ("\\([:|]-*P\\)\\W" 1 "FaceYukky.xpm")) ! "A list of regexps to map smilies to real images.") (defvar smiley-flesh-color "yellow" "Flesh color.") --- 60,91 ---- ("\\(;-*[>)}»]+\\)\\W" 1 "FaceWinking.xpm") ("\\(:-*[Vvµ]\\)\\W" 1 "FaceWry.xpm") ("\\([:|]-*P\\)\\W" 1 "FaceYukky.xpm")) ! "Normal and deformed faces for smilies.") ! ! (defvar smiley-nosey-regexp-alist ! '(("\\(:-+[<«]+\\)\\W" 1 "FaceAngry.xpm") ! ("\\(:-+\\]+\\)\\W" 1 "FaceGoofy.xpm") ! ("\\(:-+D\\)\\W" 1 "FaceGrinning.xpm") ! ("\\(:-+[}»]+\\)\\W" 1 "FaceHappy.xpm") ! ("\\(:-*)+\\)\\W" 1 "FaceHappy.xpm") ;; The exception that confirms the rule ! ("\\(:-+[/\\\"]+\\)\\W" 1 "FaceIronic.xpm") ! ("\\([8|]-+[|Oo%]\\)\\W" 1 "FaceKOed.xpm") ! ("\\([:|]-+#+\\)\\W" 1 "FaceNyah.xpm") ! ("\\(:-+[({]+\\)\\W" 1 "FaceSad.xpm") ! ("\\(:-+[Oo\*]\\)\\W" 1 "FaceStartled.xpm") ! ("\\(:-+|\\)\\W" 1 "FaceStraight.xpm") ! ("\\(:-+p\\)\\W" 1 "FaceTalking.xpm") ! ("\\(:-+d\\)\\W" 1 "FaceTasty.xpm") ! ("\\(;-+[>)}»]+\\)\\W" 1 "FaceWinking.xpm") ! ("\\(:-+[Vvµ]\\)\\W" 1 "FaceWry.xpm") ! ("\\([:|]-+P\\)\\W" 1 "FaceYukky.xpm")) ! "Smileys with noses. These get less false matches.") ! ! (defvar smiley-regexp-alist smiley-deformed-regexp-alist ! "A list of regexps to map smilies to real images. ! Defaults to the content of smiley-deformed-regexp-alist. ! An alternative smiley-nose-regexp-alist that ! matches less aggresively is available.") (defvar smiley-flesh-color "yellow" "Flesh color.") Greetings, Jan P.S. Should the "nosey" verion match ":)" it still gives some false matches, but a quick look in rec.humor showed that it is used a lot. -- Jan Vroonhof http://www.math.ethz.ch/~vroonhof/ Mathematik, vroonhof@math.ethz.ch HG E16, ETH-Zentrum, Tel: +41-1-6325456/25154 Raemistrasse 101, CH-8092 Zuerich. Fax: +41-1-6321085