Re: Red Gnus v0.61 is released

[Jan Vroonhof <vroonhof@math.ethz.ch>]

Lars Magne Ingebrigtsen <larsi@ifi.uio.no> writes:

> Jan Vroonhof <vroonhof@math.ethz.ch> writes:
> 
> > Lars, please remove this patch (it's very ugly hack IMHO anyway, you
> > are braking very basic Emacs semantics here). Please Please.
> 
> Nope, nope.  It's quite nice, actually, since the only other solution
> is to delete all the .elc files first.

It's ugly. It's ugly. It's ugly. :-P . What Gnus does with its own
files is its problem but it should never EVER load other .el files
before .elc files. That just isn't right. What you want is to not load
the Gnus .elc if you have never .el files. Just get rid of them:

> > I have my mail-utils.el gzipped so that the .el version of that
> > doesn't exist either. There are probably other people who have
> > thrown out the .el files altogether.
> 
> Fix in Red Gnus v0.62.

What If I am hacking mail-utils.el at the moment?

> Just trust me.  It's the right thing to do.  :-)

Trust me, just apply this patch :-)

--- dgnushack.el.orig	Thu Nov 14 16:25:27 1996
+++ dgnushack.el	Thu Nov 14 19:12:35 1996
@@ -37,16 +37,6 @@
 (defalias 'efs-re-read-dir 'ignore)
 (defalias 'ange-ftp-re-read-dir 'ignore)
 
-(fset 'orig-require (symbol-function 'require))
-
-(defun require (package &optional file)
-  "Avoid loading .elc files."
-  (let ((filename (concat (symbol-name package) ".el")))
-    (condition-case err
-	(orig-require package filename)
-      (error
-       (orig-require package)))))
-
 (eval-and-compile
   (unless (string-match "XEmacs" emacs-version)
     (fset 'get-popup-menu-response 'ignore)
@@ -59,11 +49,19 @@
   (let ((files (directory-files "." nil ".el$"))
 	(xemacs (string-match "XEmacs" emacs-version))
 	;;(byte-compile-generate-call-tree t)
-	byte-compile-warnings file elc)
+	byte-compile-warnings file comp-files elc)
     (condition-case ()
 	(require 'w3-forms)
       (error (setq files (delete "nnweb.el" files))))
+    (setq files (delete "dgnushack.el" files))
+;; Delete offending .elc files if we are going to recreate them anyway    
     (while (setq file (pop files))
+	(when (file-newer-than-file-p file (setq elc (concat file "c")))
+	  (progn
+	    (push file comp-files)
+	    (when (file-exists-p elc)
+	       (delete-file elc)))))
+    (while (setq file (pop comp-files))
       (cond 
        ((or (string= file "custom.el") (string= file "browse-url.el"))
 	(setq byte-compile-warnings nil))
@@ -77,10 +75,8 @@
 				    "messagexmas.el" "nnheaderxm.el"
 				    "smiley.el")))
 		xemacs)
-	(when (or (not (file-exists-p (setq elc (concat file "c"))))
-		  (file-newer-than-file-p file elc))
 	  (ignore-errors
-	    (byte-compile-file file)))))))
+	    (byte-compile-file file))))))
 
 (defun dgnushack-recompile ()
   (require 'gnus)