Gnus development mailing list
 help / color / mirror / Atom feed
From: Ralf Angeli <angeli@iwi.uni-sb.de>
Subject: Quoted empty lines and format=flowed
Date: Fri, 24 Feb 2006 10:50:23 +0100	[thread overview]
Message-ID: <dtmksp$9ck$1@sea.gmane.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1522 bytes --]

Hi,

this is actually an old problem (see the discussion following
<http://mid.gmane.org/bqiihe$12f$1@quimby.gnus.org> on ding) which bit
me again because one cannot disable the treatment of format=flowed
messages by means of `mm-fill-flowed' with the Gnus version in current
CVS Emacs.  (Reiner told me that he will change this.)

The problem itself is a bogus line break when a message is displayed
which includes a quoted empty line with a trailing space followed by a
long line with no trailing space.  As an example I attached a small
file which can be used for testing with `emacs -Q -l flow-fill
test.txt -eval "(fill-flowed)"'.

The result should look like this

>>xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
>>xxxxxxxxxxxxxxxxxxxxxxxxxxxxx.
> xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx?
> Xxx
> xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx?

while I would have expected this

>>xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
>>xxxxxxxxxxxxxxxxxxxxxxxxxxxxx.
>
> xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx?  Xxx
> xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx?

If I understand RFC3676 correctly one could get rid of this problem by
removing space-stuffing not only at the start of lines but also after
quote marks.  While it would conform to RFC3676 I am not sure if
people would like to have quoted text be displayed without spacing
between quote marks and text. Thus, the following patch removes
space-stuffing only for quoted empty lines:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 436 bytes --]

--- /usr/src/gnus/lisp/flow-fill.el.~7.15.~	2006-02-22 15:51:58 +0100
+++ /usr/src/gnus/lisp/flow-fill.el	2006-02-24 10:20:04 +0100
@@ -103,7 +103,7 @@
     (set-buffer (or (current-buffer) buffer))
     (goto-char (point-min))
     ;; Remove space stuffing.
-    (while (re-search-forward "^ " nil t)
+    (while (re-search-forward "^\\( \\|>+ $\\)" nil t)
       (delete-char -1)
       (forward-line 1))
     (goto-char (point-min))

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]


I am aware that this is rather a band-aid than a real fix, but anyway.
If something like that is acceptable I can provide a ChangeLog entry
as well.

-- 
Ralf

[-- Attachment #4: test.txt --]
[-- Type: text/plain, Size: 218 bytes --]

>>xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
>>xxxxxxxxxxxxxxxxxxxxxxxxxxxxx.
> 
> xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx?  Xxx
> xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx?

             reply	other threads:[~2006-02-24  9:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-24  9:50 Ralf Angeli [this message]
2006-04-12  5:56 ` Lars Magne Ingebrigtsen
2006-04-12 15:30   ` Reiner Steib
2006-04-12 20:28     ` Ralf Angeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='dtmksp$9ck$1@sea.gmane.org' \
    --to=angeli@iwi.uni-sb.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).