Gnus development mailing list
 help / color / mirror / Atom feed
From: NAGY Andras <nagya@inf.elte.hu>
Cc: bugs@gnus.org
Subject: [patch] imap.el imap-gssapi-open fix
Date: 15 Feb 2001 00:48:47 +0100	[thread overview]
Message-ID: <dzcwvas25cw.fsf@pandora.inf.elte.hu> (raw)

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

Symptom: using nnimap with gssapi authentication (with external imtest
program), unable to upload messages.

Problem: the APPEND command needs to know the exact size of the
message to be uplaoded, which should be calculated using two-byte line
terminator size.  Unlike other transports, imtest requires "\n" as
line the terminator instead of "\r\n".  Gnus calculates the size after
changing the line terminator to "\n", causing wrong result.

Solution: in imap-gssapi-open, set imap-calculate-literal-size-first
to the correct value, besides imap-client-eol, as seen in
imap-kerberos4-open.

Other possible occurrence: imap-shell-open also sets imap-client-eol
but not imap-calculate-literal-size-first.  As I'm unable to test
this, not included in the patch.


Patch:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: imap.el.patch-gss --]
[-- Type: text/x-patch, Size: 451 bytes --]

diff -u -r6.3 imap.el
--- imap.el	2000/12/19 22:18:56	6.3
+++ imap.el	2001/02/14 23:43:38
@@ -521,7 +521,8 @@
 	     response)
 	(when process
 	  (with-current-buffer buffer
-	    (setq imap-client-eol "\n")
+	    (setq imap-client-eol "\n"
+		  imap-calculate-literal-size-first t)
 	    (while (and (memq (process-status process) '(open run))
 			(goto-char (point-min))
                         ;; cyrus 1.6.x (13? < x <= 22) queries capabilities

[-- Attachment #3: Type: text/plain, Size: 9 bytes --]



Andras

             reply	other threads:[~2001-02-14 23:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-02-14 23:48 NAGY Andras [this message]
2001-02-15  9:22 ` Simon Josefsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dzcwvas25cw.fsf@pandora.inf.elte.hu \
    --to=nagya@inf.elte.hu \
    --cc=bugs@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).