From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/62431 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.gnus.general Subject: Re: default-enable-multibyte-characters in pgg-gpg Date: Wed, 29 Mar 2006 20:59:04 +0900 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1143633616 31808 80.91.229.2 (29 Mar 2006 12:00:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 29 Mar 2006 12:00:16 +0000 (UTC) Cc: ding@gnus.org, Frank =?ISO-8859-1?Q?K=FCster?= Original-X-From: ding-owner+m10958@lists.math.uh.edu Wed Mar 29 14:00:13 2006 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FOZLJ-0005Qr-Kn for ding-account@gmane.org; Wed, 29 Mar 2006 14:00:05 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1FOZLE-0005zs-00; Wed, 29 Mar 2006 06:00:00 -0600 Original-Received: from nas01.math.uh.edu ([129.7.128.39]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1FOZK7-0005zm-00 for ding@lists.math.uh.edu; Wed, 29 Mar 2006 05:58:51 -0600 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas01.math.uh.edu with esmtp (Exim 4.52) id 1FOZK5-0007i3-4E for ding@lists.math.uh.edu; Wed, 29 Mar 2006 05:58:51 -0600 Original-Received: from 221x255x76x220.ap221.ftth.ucom.ne.jp ([221.255.76.220] helo=localhost) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1FOZK3-0002Ea-00 for ; Wed, 29 Mar 2006 13:58:48 +0200 Original-Received: from localhost ([127.0.0.1] helo=well-done.deisui.org ident=ueno) by localhost with esmtp (Exim 4.60) (envelope-from ) id 1FOZKK-000103-D5; Wed, 29 Mar 2006 20:59:04 +0900 Original-To: Reiner Steib X-Attribution: DU In-Reply-To: (Reiner Steib's message of "Wed, 29 Mar 2006 13:24:18 +0200") User-Agent: T-gnus/6.17.3 (based on No Gnus v0.3) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 XEmacs/21.4.16 (i686-pc-linux) MULE X-Spam-Score: -2.6 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:62431 Archived-At: Hello Reiner, >>>>> In >>>>> Reiner Steib wrote: > > Setting default-enable-multibyte-characters in pgg-gpg-start-process > > makes GnuPG messages unreadable under multibyte locales. > > > > I found the article which introduced this change: > > http://article.gmane.org/gmane.emacs.gnus.general/50457 > > I think this case is rare, and doubt that this really fixed the problem. > At least Frank has confirmed that it does fix it for him in > . Could you > suggest a better fix? Maybe we could bind enable-multibyte-characters > only in some of the callers of `pgg-gpg-start-process', where > appropriate? > > Could anyone who can use a German keyboard check the attached patch? > As your patch just reverts this patch, I'd guess that it will > reintroduce the problem the other patch tried to solve. Ah, I understand why this was necessary at that time. When the patch was introduced, pgg-gpg used synchronous code and sent a passphrase together with data on a temp buffer: (defun pgg-gpg-process-region (start end passphrase program args) ... (let ((coding-system-for-write 'binary) (input (buffer-substring-no-properties start end)) (default-enable-multibyte-characters nil)) (with-temp-buffer (when passphrase (insert passphrase "\n")) (insert input) (setq exit-status (apply #'call-process-region (point-min) (point-max) program nil errors-buffer nil args)))) So I think setting default-enable-multibyte-characters is no longer necessary because we switched to use asynchronous code and passphrases are sent separately. Regards, -- Daiki Ueno