Makefile bug.

Makefile bug.

[Gaute B Strokkenes]

I'm not sure if this is the right place to report this, but when I did
a make install with CVS gnus as of a few minutes ago, make tried to
create a directory called /emacs and died.  If my analysis is correct
this is due to a missing datadir = @datadir@ in gnus/etc/Makefile.in


Additionally, the install target could not deal with a gnus configured
like this:

  $ ./configure --prefix=~/elisp/gnus

It worked when I changed it to

  $ ./configure --prefix=$HOME/elisp/gnus

I'm not certain if this is supposed to work or not, but I don't see
why it shouldn't.  The failure symptoms are mkinstalldirs silently
failing to create the necessary directories.

-- 
Big Gaute                               http://www.srcf.ucam.org/~gs234/
I'm having a MID-WEEK CRISIS!

Index: Makefile.in
===================================================================
RCS file: /usr/local/cvsroot/gnus/etc/Makefile.in,v
retrieving revision 1.2
diff -u -p -r1.2 Makefile.in
--- Makefile.in	2000/12/25 05:48:41	1.2
+++ Makefile.in	2001/05/16 06:43:26
@@ -1,3 +1,4 @@
+datadir = @datadir@
 infodir = @infodir@
 prefix = @prefix@
 srcdir = @srcdir@

Re: Makefile bug.

[Kai Großjohann]

On 16 May 2001, Gaute B. Strokkenes wrote:

> Additionally, the install target could not deal with a gnus
> configured like this:
> 
>   $ ./configure --prefix=~/elisp/gnus
> 
> It worked when I changed it to
> 
>   $ ./configure --prefix=$HOME/elisp/gnus

Try the following two commands.  They should produce the same output.

    echo ./configure --prefix=~/elisp/gnus
    echo ./configure --prefix=$HOME/elisp/gnus

Do they?

kai
-- 
The passive voice should never be used.

Re: Makefile bug.

[Peter Makholm]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> Try the following two commands.  They should produce the same output.
> 
>     echo ./configure --prefix=~/elisp/gnus
>     echo ./configure --prefix=$HOME/elisp/gnus

>From man bash:

   Tilde Expansion
       If  a  word begins with an unquoted tilde character (`~'),
       all of the characters preceding the first  unquoted  slash
       (or  all  characters,  if  there is no unquoted slash) are
       considered a tilde-prefix.

And it seems that the tilde in the above example isn't considered at
the beginning of a word.

-- 
hash-bang-slash-bin-slash-bash

Re: Makefile bug.

[Gaute B Strokkenes]

On 16 May 2001, Kai.Grossjohann@CS.Uni-Dortmund.DE wrote:
> On 16 May 2001, Gaute B. Strokkenes wrote:
> 
>> Additionally, the install target could not deal with a gnus
>> configured like this:
>> 
>>   $ ./configure --prefix=~/elisp/gnus
>> 
>> It worked when I changed it to
>> 
>>   $ ./configure --prefix=$HOME/elisp/gnus
> 
> Try the following two commands.  They should produce the same
> output.
> 
>     echo ./configure --prefix=~/elisp/gnus
>     echo ./configure --prefix=$HOME/elisp/gnus
> 
> Do they?

No.  The twiddle is still there in the first one.

-- 
Big Gaute                               http://www.srcf.ucam.org/~gs234/
Is this ANYWHERE, USA?

Re: Makefile bug.

[Kai Großjohann]

On 16 May 2001, Gaute B. Strokkenes wrote:

> On 16 May 2001, Kai.Grossjohann@CS.Uni-Dortmund.DE wrote:
>
>> Try the following two commands.  They should produce the same
>> output.
>> 
>>     echo ./configure --prefix=~/elisp/gnus
>>     echo ./configure --prefix=$HOME/elisp/gnus
>> 
>> Do they?
> 
> No.  The twiddle is still there in the first one.

Ayeee!  Look here:

/----
| grossjoh@lucy> echo configure --prefix=~/foo/bar
| configure --prefix=~/foo/bar
| grossjoh@lucy> echo configure prefix=~/foo/bar
| configure prefix=/home-local/grossjoh/foo/bar
\----

It is not at all obvious why omitting the `--' should change the
behavior of bash regarding tilde expansion.  But apparently, it does!
Argh.

kai
-- 
The passive voice should never be used.

Re: Makefile bug.

[Denys Duchier]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> /----
> | grossjoh@lucy> echo configure --prefix=~/foo/bar
> | configure --prefix=~/foo/bar
> | grossjoh@lucy> echo configure prefix=~/foo/bar
> | configure prefix=/home-local/grossjoh/foo/bar
> \----
> 
> It is not at all obvious why omitting the `--' should change the
> behavior of bash regarding tilde expansion.  But apparently, it does!
> Argh.

Quoting from the bash info documentation:

1. "Expansion is performed on the command line after it has been split
into `token's.  There are seven kinds of expansion performed:"

2. "Each variable assignment is checked for unquoted tilde-prefixes
immediately following a `:' or `='.  In these cases, tilde expansion is
also performed."

Cheers,

-- 
Dr. Denys Duchier			Denys.Duchier@ps.uni-sb.de
Forschungsbereich Programmiersysteme	(Programming Systems Lab)
Universitaet des Saarlandes, Geb. 45	http://www.ps.uni-sb.de/~duchier
Postfach 15 11 50			Phone: +49 681 302 5618
66041 Saarbruecken, Germany		Fax:   +49 681 302 5615

Re: Makefile bug.

[Michael.Cook]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> It is not at all obvious why omitting the `--' should change the
> behavior of bash regarding tilde expansion.  But apparently, it does!
> Argh.

moreover, in bash version 1.14.7, the ~ in --prefix=~/ is expanded,
but in bash version 2.03.8, the ~ is not expanded.

Re: Makefile bug.

[Kai Großjohann]

On 16 May 2001, Denys Duchier wrote:
> Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:
> 
>> /----
>> | grossjoh@lucy> echo configure --prefix=~/foo/bar
>> | configure --prefix=~/foo/bar
>> | grossjoh@lucy> echo configure prefix=~/foo/bar
>> | configure prefix=/home-local/grossjoh/foo/bar
>> \----
> 
> 2. "Each variable assignment is checked for unquoted tilde-prefixes
> immediately following a `:' or `='.  In these cases, tilde expansion
> is also performed."

Right.  However, I see no variable assignments in the above shell
code.  (Only things which look like variable assignments.)

kai
-- 
The passive voice should never be used.

Re: Makefile bug.

[Gaute B Strokkenes]

On 16 May 2001, Denys.Duchier@ps.uni-sb.de wrote:
> Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:
> 
>> /----
>> | grossjoh@lucy> echo configure --prefix=~/foo/bar
>> | configure --prefix=~/foo/bar
>> | grossjoh@lucy> echo configure prefix=~/foo/bar
>> | configure prefix=/home-local/grossjoh/foo/bar
>> \----
>> 
>> It is not at all obvious why omitting the `--' should change the
>> behavior of bash regarding tilde expansion.  But apparently, it
>> does!  Argh.
> 
> Quoting from the bash info documentation:
> 
> 1. "Expansion is performed on the command line after it has been
> split into `token's.  There are seven kinds of expansion performed:"
> 
> 2. "Each variable assignment is checked for unquoted tilde-prefixes
> immediately following a `:' or `='.  In these cases, tilde expansion
> is also performed."

I wouldn't be surprised if the exhibited behaviour is correct acording
to the relevant standards, but it's not intuitive.

Personally, I'd rather see that Makefile.in thing fixed.  Surely I'm
not the only one who's seeing this?

-- 
Big Gaute                               http://www.srcf.ucam.org/~gs234/
My FAVORITE group is "QUESTION MARK & THE MYSTERIANS"...

Re: Makefile bug.

[Karl Kleinpaste]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:
> It is not at all obvious why omitting the `--' should change the
> behavior of bash regarding tilde expansion.  But apparently, it does!

I asked Chet about it, on gnu.bash.bug.


[-- Attachment #2: bash `~' expansion, with/without leading \"--\" --]
[-- Type: message/rfc822, Size: 2401 bytes --]

From: chet@nike.ins.cwru.edu (Chet Ramey)
Subject: Re: leading "--" changes whether `~' is expanded?
Date: Wed, 16 May 2001 09:48:17 -0400
Message-ID: <010516134817.AA53910.SM@nike.ins.cwru.edu>

> This question arose on the Gnus development list, in debugging why
> ./configure's invocation was not behaving as expected.
> 
> [1546] [08:51:55] cinnamon:~> echo $BASH_VERSION
> 2.05.0(1)-release
> [1546] [08:51:56] cinnamon:~> echo ./configure prefix=~karl
> ./configure prefix=/home/karl
> [1547] [08:52:03] cinnamon:~> echo ./configure --prefix=~karl
> ./configure --prefix=~karl
> 
> The difference is only in whether the "--" is part of the last
> argument.  It was further observed that 1.14 expands the `~'
> regardless of the presence of "--".
> 
> Any reason why this is the case?  It doesn't seem (from reading the
> bash 2.05 manual page) that the conception of a "word" in Tilde
> Expansion should be affected by the dashes.

Bash does tilde expansion in words that appear to be variable
assignments (POSIX.2, section 3.6.1).  POSIX says to do it only for
assignment statements preceding a command, but bash does it for any
word that looks like an assignment statement (unless bash is running
in posix mode).  Since the leading `--' makes an invalid lhs for a
variable assignment, --prefix=~xxx is not a candidate for tilde
expansion.  However, `make DESTDIR=~/bin' would be tilde expanded,
even though POSIX says not to.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
( ``Discere est Dolere'' -- chet)

Chet Ramey, CWRU    chet@po.CWRU.Edu    http://cnswww.cns.cwru.edu/~chet/

Re: Makefile bug.

[Kai Großjohann]

On 16 May 2001, Gaute B. Strokkenes wrote:

> Personally, I'd rather see that Makefile.in thing fixed.  Surely I'm
> not the only one who's seeing this?

It's not the job of the Makefile to do tilde expansion, that's the job
of the shell.  I don't think it's a good idea to want to do tilde
expansion in the Makefile -- while expanding `~' does not appear to be
difficult (just use $HOME), consider `~jrl' which is not so easy (the
user could be in /etc/passwd, or NIS, or NIS+, or NetInfo).

kai
-- 
The passive voice should never be used.

Re: Makefile bug.

[Kai Großjohann]

On 16 May 2001, Karl Kleinpaste wrote:

> [[ Quoting Chet Ramey: ]]
> 
> Bash does tilde expansion in words that appear to be variable
> assignments (POSIX.2, section 3.6.1).  POSIX says to do it only for
> assignment statements preceding a command, but bash does it for any
> word that looks like an assignment statement (unless bash is running
> in posix mode).  Since the leading `--' makes an invalid lhs for a
> variable assignment, --prefix=~xxx is not a candidate for tilde
> expansion.  However, `make DESTDIR=~/bin' would be tilde expanded,
> even though POSIX says not to.

IMVHO it would be useful for bash to tilde-expand `--prefix=~/foo'.
If I understand Chet correctly, bash has a posixly correct and a
normal mode -- how about tilde-expanding `--prefix=~/foo' in normal
mode (but to refrain from expanding in posixly correct mode)?

kai
-- 
The passive voice should never be used.

Re: Makefile bug.

[Denys Duchier]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> Right.  However, I see no variable assignments in the above shell
> code.  (Only things which look like variable assignments.)

That's why I quoted the bit about first splitting the command line
into `tokens'.  If prefix=~/foo/bar occurred first, it would really be
a variable assignment.  There's probably no way to tell the difference
during expansion.

Cheers,

-- 
Dr. Denys Duchier			Denys.Duchier@ps.uni-sb.de
Forschungsbereich Programmiersysteme	(Programming Systems Lab)
Universitaet des Saarlandes, Geb. 45	http://www.ps.uni-sb.de/~duchier
Postfach 15 11 50			Phone: +49 681 302 5618
66041 Saarbruecken, Germany		Fax:   +49 681 302 5615

Re: Makefile bug.

[Alexandre Oliva]

On May 16, 2001, Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) wrote:

> how about tilde-expanding `--prefix=~/foo' in normal mode (but to
> refrain from expanding in posixly correct mode)?

How about using `--prefix ~/foo'?

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist    *Please* write to mailing lists, not to me

Re: Makefile bug.

[Raja R Harinath]

Hi,

Gaute B Strokkenes <gs234@cam.ac.uk> writes:
> I'm not sure if this is the right place to report this, but when I did
> a make install with CVS gnus as of a few minutes ago, make tried to
> create a directory called /emacs and died.  If my analysis is correct
> this is due to a missing datadir = @datadir@ in gnus/etc/Makefile.in
> 
> 
> Additionally, the install target could not deal with a gnus configured
> like this:
> 
>   $ ./configure --prefix=~/elisp/gnus

If you really want to use ~ expansion this way, try

   ./configure --prefix ~/elisp/gnus

- Hari
-- 
Raja R Harinath ------------------------------ harinath@cs.umn.edu
"When all else fails, read the instructions."      -- Cahn's Axiom
"Our policy is, when in doubt, do the right thing."   -- Roy L Ash

Re: Makefile bug.

[Gaute B Strokkenes]

On 16 May 2001, Kai.Grossjohann@CS.Uni-Dortmund.DE wrote:
> On 16 May 2001, Gaute B. Strokkenes wrote:
> 
>> Personally, I'd rather see that Makefile.in thing fixed.  Surely
>> I'm not the only one who's seeing this?
> 
> It's not the job of the Makefile to do tilde expansion, that's the
> job of the shell.  I don't think it's a good idea to want to do
> tilde expansion in the Makefile -- while expanding `~' does not
> appear to be difficult (just use $HOME), consider `~jrl' which is
> not so easy (the user could be in /etc/passwd, or NIS, or NIS+, or
> NetInfo).

You're confused.  This is not what I'm talking about at all; please
re-read my original message.

-- 
Big Gaute                               http://www.srcf.ucam.org/~gs234/
.. If I cover this entire WALL with MAZOLA, wdo I have to give my
 AGENT ten per cent??

Re: Makefile bug.

[Gaute B Strokkenes]

On 16 May 2001, oliva@lsd.ic.unicamp.br wrote:
> On May 16, 2001, Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann)
> wrote:
> 
>> how about tilde-expanding `--prefix=~/foo' in normal mode (but to
>> refrain from expanding in posixly correct mode)?
> 
> How about using `--prefix ~/foo'?

gs234@kern:~/gnus$ ./configure --help
Usage: configure [options] [host]
Options: [defaults in brackets after descriptions]
Configuration:
  --cache-file=FILE       cache test results in FILE
  --help                  print this message
  --no-create             do not create output files
  --quiet, --silent       do not print `checking...' messages
  --version               print the version of autoconf that created configure
Directory and file names:
  --prefix=PREFIX         install architecture-independent files in PREFIX
                          [/usr/local]
...

Note the = in --prefix=PREFIX.  I was just following instructions,
guv'nor.  8-)

-- 
Big Gaute                               http://www.srcf.ucam.org/~gs234/
Do I have a lifestyle yet?

Re: Makefile bug.

[Kai Großjohann]

On 16 May 2001, Gaute B. Strokkenes wrote:
> 
> I'm not sure if this is the right place to report this, but when I
> did a make install with CVS gnus as of a few minutes ago, make tried
> to create a directory called /emacs and died.  If my analysis is
> correct this is due to a missing datadir = @datadir@ in
> gnus/etc/Makefile.in

I applied the patch, thanks.

kai
-- 
The passive voice should never be used.

Re: Makefile bug.

[Kai Großjohann]

On 17 May 2001, Gaute B. Strokkenes wrote:

> You're confused.  This is not what I'm talking about at all; please
> re-read my original message.

Oh, I see.  Sorry.

kai
-- 
The passive voice should never be used.