Re: Patches for cvs and cvslog

[Michael Cook <michael.cook@cisco.com>]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> I've included the patch below, but remember: I don't know any Perl, so
> try not to hurt yourself too badly when you fall off your chair,
> laughing.  :-)

it looks pretty reasonable.  you probably want to close PASSWD.  and
a couple other performance tweaks would be easy if you're inclined:

  }
  $data{messages} = [ $data{message} ] unless $data{messages};
 
  my $from_line = "";
  
  if (open (PASSWD, "/usr/local/cvsroot/CVSROOT/passwd")) {
      my $passwd_user = $ENV{CVSUSER};
-     my $full_name = "CVS";
-     my $email_address = "cvs\@" . `hostname --fqdn`;
-     chomp $email_address;
+     my $full_name;
+     my $email_address;
      my $line;
      my @info;
      while ($line = <PASSWD>) {
  	chomp $line;
  	@info = split (/:/, $line);
  	if ($info[0] eq $passwd_user) {
  	    $full_name = $info[3];
  	    $email_address = $info[4];
+ 	    last;
  	}
+     }
+     close PASSWD;
+     unless (defined $full_name)
+     {
+	$full_name = "CVS";
+	$email_address = "cvs\@" . `hostname --fqdn`;
+	chomp $email_address;
      }
      $from_line = "From: \"$full_name\" <$email_address>\n";
  }
  
  # Open our mail program.
  open (MAIL, '| /usr/lib/sendmail -t -oi -oem')
      or die "$0: can't fork /usr/lib/sendmail: $!\n";

m.