Re: Cry for help: deuglify.el - moving stuff in the Article Buffer

[Raymond Scholz <ray-2002@zonix.de>]

* Lars Magne Ingebrigtsen <larsi@gnus.org> wrote:

> Raymond Scholz <ray-2002@zonix.de> writes:
>
>> If you're using `W k' to deuglify messages, you may have encountered
>> the problem that messages with MIME parts (or format=flowed)
>> completely disappear from the Article Buffer.  This is due to the
>> brain-dead implementation of `gnus-outlook-rearrange-article'
>
> Could you construct a message that displays this behavior?

Instead of doing another try to construct such a message, I hopefully
fixed some bugs in deuglify.el.

Here is a diff against CVS:

Index: lisp/deuglify.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/deuglify.el,v
retrieving revision 6.4
diff -u -r6.4 deuglify.el
--- lisp/deuglify.el	2002/12/28 23:54:45	6.4
+++ lisp/deuglify.el	2002/12/31 00:03:05
@@ -280,7 +280,6 @@
 
 ;; Functions
 
-;; TODO: don't kill MIME parts
 ;;;###autoload
 (defun gnus-outlook-unwrap-lines ()
   "Unwrap lines that appear to be wrapped citation lines.
@@ -311,20 +310,19 @@
 		  (replace-match "\\1\\2 \\3")
 		  (goto-char (match-beginning 0))))))))))
 
-;; TODO: respect signatures, don't kill MIME parts
 (defun gnus-outlook-rearrange-article (from-where)
-  "Put the text from `from-where' to the end of buffer at the top of the article buffer."
+  "Put the text from `from-where' to the end of buffer at the top of
+the article buffer."
   (save-excursion
     (let ((inhibit-read-only t)
 	  (cite-marks gnus-outlook-deuglify-cite-marks))
       (gnus-with-article-buffer
-	(unless (search-forward-regexp
-		   (concat "^[ \t]*[^" cite-marks "\n]") nil t)
-	  (kill-region from-where (point-max))
-	  (article-goto-body)
-	  (yank)
-	  (insert "\n"))))))
+	(beginning-of-buffer)
+	(re-search-forward "^$")
+	(transpose-regions (point) (- from-where 1)
+			   from-where (point-max) t)))))
 
+
 ;; John Doe <john.doe@some.domain> wrote in message
 ;; news:a87usw8$dklsssa$2@some.news.server...
 
@@ -425,7 +423,7 @@
   (interactive)
   (gnus-outlook-deuglify-article)
   (with-current-buffer (or gnus-article-buffer (current-buffer))
-    (gnus-article-prepare-display)))
+    (gnus-article-highlight t)))
 
 (provide 'deuglify)




Suggested ChangeLog:

2002-12-31  Raymond Scholz  <ray-2002@zonix.de>

	* deuglify.el (gnus-outlook-rearrange-article): Use
	`transpose-regions' instead of tempering the kill-ring.
	(gnus-article-outlook-deuglify-article): Rehighlight article
	instead of a complete redisplay.

Cheers, Ray
-- 
Hfr fgebat rapelcgvba!