Re: patches add variable `gnus-confirm-mail-reply-to-news'

[Raymond Scholz <ray-2002@zonix.de>]

[Full quote, because the original posting is rather erm... well, what
 time makes of a posting that has been forgotten in a folder named
 "TODO" for some months]

* Simon Josefsson <jas@extundo.com> wrote:

> Raymond Scholz <ray-2002@zonix.de> writes:
>
>> Simon Josefsson <jas@extundo.com> writes:
>>
>>> I agree. Ok, I added the original patch that defaults to not asking.  Thanks.
>>
>> I used to have this in my .gnus for ages:
>>
>> (setq rs-mailing-lists "list\\.")
>>
>> ;; Patric Mueller in <7iq1t9.m63.ln@bhaak.xodox.com>
>> ;; von mir erweitert um die Abfrage auf Mailinglisten 
>> (defadvice gnus-summary-reply (around reply-in-news activate)
>>   (when (or
>> 	 (not (or (gnus-news-group-p 
>> 		   (if (gnus-virtual-group-p gnus-newsgroup-name)
>> 		       (car (nnvirtual-map-article (cdr gnus-article-current)))
>> 		     gnus-newsgroup-name
>> 		     ))
>> 		  (string-match rs-mailing-lists gnus-newsgroup-name)))
>> 	 (y-or-n-p "Really, really reply? "))
>>     ad-do-it))
>>
>> It adds "support" for virtual groups that contain newsgroups and for
>> user defined lists (all of my mailing lists) where I usually don't
>> want to say `R'.
>>
>> Would it be useful to be added to Gnus or is it too specifically
>> tailored for my personal needs?
>
> I didn't test this, but it should add support for setting the variable
> to a string or function to get the behaviour you want.  Does it work?
>
> --- gnus-msg.el.~6.90.~	Thu May 23 23:57:20 2002
> +++ gnus-msg.el	Sun May 26 21:09:26 2002
> @@ -242,9 +242,15 @@
>  (defcustom gnus-confirm-mail-reply-to-news nil
>    "If non-nil, Gnus requests confirmation when replying to news.
>  This is done because new users often reply by mistake when reading
> -news."
> +news.
> +This can also be a function which should return non-nil iff a
> +confirmation is needed, or a regexp, in which case a confirmation is
> +asked if the group name matches the regexp."
>    :group 'gnus-message
> -  :type 'boolean)
> +  :type '(choice (const :tag "No" nil)
> +		 (const :tag "Yes" nil)
> +		 (regexp :tag "Iff group matches regexp")
> +		 (function :tag "Iff function evaluates to non-nil")))
>
>  ;;; Internal variables.
>
> @@ -988,7 +994,11 @@
>    ;; Allow user to require confirmation before replying by mail to the
>    ;; author of a news article.
>    (when (or (not (gnus-news-group-p gnus-newsgroup-name))
> -	    (not gnus-confirm-mail-reply-to-news)
> +	    (not (cond ((stringp gnus-confirm-mail-reply-to-news)
> +			(string-match gnus-confirm-mail-reply-to-news gnus-newsgroup-name))
> +		       ((functionp gnus-confirm-mail-reply-to-news)
> +			(funcall gnus-confirm-mail-reply-to-news))
> +		       (t gnus-confirm-mail-reply-to-news)))
>  	    (y-or-n-p "Really reply by mail to article author? "))
>      (let* ((article
>  	    (if (listp (car yank))

This kind of works for news groups but it doesn't for mail because
(gnus-news-group-p gnus-newsgroup-name) is always nil then.  As I
treat mailing lists like news groups regarding personal replies, the
only way to solve this is to disable this condition.  What about
another variable like `gnus-confirm-treat-mail-like-news'?

--- gnus-msg.el	2002/09/25 23:45:17	6.100
+++ gnus-msg.el	2002/10/16 16:22:51
@@ -256,8 +256,23 @@
 (defcustom gnus-confirm-mail-reply-to-news nil
   "If non-nil, Gnus requests confirmation when replying to news.
 This is done because new users often reply by mistake when reading
-news."
+news.
+This can also be a function which should return non-nil iff a
+confirmation is needed, or a regexp, in which case a confirmation is
+asked if the group name matches the regexp."
   :group 'gnus-message
+  :type '(choice (const :tag "No" nil)
+		 (const :tag "Yes" nil)
+		 (regexp :tag "Iff group matches regexp")
+		 (function :tag "Iff function evaluates to non-nil")))
+
+(defcustom gnus-confirm-treat-mail-like-news
+  nil
+  "If non-nil, Gnus will treat mail like news with regard to confirmation
+when replying by mail.  See the `gnus-confirm-mail-reply-to-news' variable
+for fine-tuning this.
+If nil, Gnus will never ask for confirmation if replying to mail."
+  :group 'gnus-message
   :type 'boolean)
 
 (defcustom gnus-summary-resend-default-address t
@@ -1025,9 +1040,15 @@
    (list (and current-prefix-arg
 	      (gnus-summary-work-articles 1))))
   ;; Allow user to require confirmation before replying by mail to the
-  ;; author of a news article.
-  (when (or (not (gnus-news-group-p gnus-newsgroup-name))
-	    (not gnus-confirm-mail-reply-to-news)
+  ;; author of a news article (or mail message).
+  (when (or 
+	    (not (or (gnus-news-group-p gnus-newsgroup-name)
+		     gnus-confirm-treat-mail-like-news))
+	    (not (cond ((stringp gnus-confirm-mail-reply-to-news)
+			(string-match gnus-confirm-mail-reply-to-news gnus-newsgroup-name))
+		       ((functionp gnus-confirm-mail-reply-to-news)
+			(funcall gnus-confirm-mail-reply-to-news))
+		       (t gnus-confirm-mail-reply-to-news)))
 	    (y-or-n-p "Really reply by mail to article author? "))
     (let* ((article
 	    (if (listp (car yank))

Cheers, Ray
-- 
"The main failure in computers is usually between keyboard and chair."