* Invalid message-id header when unplugged.
@ 1998-09-16 4:20 Tatsuya Ichikawa
1998-09-16 7:32 ` Graham Murray
1998-09-16 9:45 ` Lars Magne Ingebrigtsen
0 siblings, 2 replies; 4+ messages in thread
From: Tatsuya Ichikawa @ 1998-09-16 4:20 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
When gnus is unplugged status , nnmail-check-syntax insert
Message-ID header like this.
Message-ID: <86emtfltdv.fsf@totally-fudged-out-message-id>
;; Message-ID is not member of message-required-news-headers.
;; In this case , I want to add Message-ID header by ISP news server.
In plugged status gnus-agent-send-drafts typing "JS" in group
buffer, Message-ID header is still above line.
Is that right ??
So , I make following patch.
Please apply in pGnus-0.32.
Thanks.
[-- Attachment #2: gnus.diff --]
[-- Type: application/octet-stream, Size: 7944 bytes --]
*** ChangeLog.orig Wed Sep 16 13:17:14 1998
--- ChangeLog Wed Sep 16 13:17:46 1998
***************
*** 1,3 ****
--- 1,17 ----
+ 1998-09-16 Tatsuya Ichikawa <ichikawa@hv.epson.co.jp>
+
+ * nnmh.el (nnmh-request-accept-article): Do not add message-id
+ when posting queue.
+
+ * gnus-agent.el (gnus-agent-file-coding-system): Renamed from
+ gnus-agent-article-file-coding-system and save in no-conversion.
+ (gnus-agent-save-group): Ditto.
+ (gnus-agent-save-history): Ditto.
+ (gnus-agent-fetch-articles): Ditto.
+ (gnus-agent-flush-cache): Ditto.
+ (gnus-agent-fetch-headers): Ditto.
+ (gnus-agent-expire): Ditto.
+
Mon Sep 14 18:55:38 1998 Lars Magne Ingebrigtsen <larsi@menja.ifi.uio.no>
* gnus.el: Pterodactyl Gnus v0.31 is released.
*** gnus-agent.el.orig Wed Sep 16 13:10:22 1998
--- gnus-agent.el Wed Sep 16 13:10:30 1998
***************
*** 92,98 ****
(defvar gnus-agent-spam-hashtb nil)
(defvar gnus-agent-file-name nil)
(defvar gnus-agent-send-mail-function nil)
! (defvar gnus-agent-article-file-coding-system 'no-conversion)
(defconst gnus-agent-scoreable-headers
(list
--- 92,98 ----
(defvar gnus-agent-spam-hashtb nil)
(defvar gnus-agent-file-name nil)
(defvar gnus-agent-send-mail-function nil)
! (defvar gnus-agent-file-coding-system 'no-conversion)
(defconst gnus-agent-scoreable-headers
(list
***************
*** 524,530 ****
(let* ((gnus-command-method method)
(file (gnus-agent-lib-file "active")))
(gnus-make-directory (file-name-directory file))
! (let ((coding-system-for-write gnus-agent-article-file-coding-system))
(write-region (point-min) (point-max) file nil 'silent))
(when (file-exists-p (gnus-agent-lib-file "groups"))
(delete-file (gnus-agent-lib-file "groups"))))))
--- 524,530 ----
(let* ((gnus-command-method method)
(file (gnus-agent-lib-file "active")))
(gnus-make-directory (file-name-directory file))
! (let ((coding-system-for-write gnus-agent-file-coding-system))
(write-region (point-min) (point-max) file nil 'silent))
(when (file-exists-p (gnus-agent-lib-file "groups"))
(delete-file (gnus-agent-lib-file "groups"))))))
***************
*** 533,541 ****
(let* ((gnus-command-method method)
(file (gnus-agent-lib-file "groups")))
(gnus-make-directory (file-name-directory file))
! (write-region (point-min) (point-max) file nil 'silent))
(when (file-exists-p (gnus-agent-lib-file "active"))
! (delete-file (gnus-agent-lib-file "active"))))
(defun gnus-agent-save-group-info (method group active)
(when (gnus-agent-method-p method)
--- 533,542 ----
(let* ((gnus-command-method method)
(file (gnus-agent-lib-file "groups")))
(gnus-make-directory (file-name-directory file))
! (let ((coding-system-for-write gnus-agent-file-coding-system))
! (write-region (point-min) (point-max) file nil 'silent))
(when (file-exists-p (gnus-agent-lib-file "active"))
! (delete-file (gnus-agent-lib-file "active")))))
(defun gnus-agent-save-group-info (method group active)
(when (gnus-agent-method-p method)
***************
*** 604,611 ****
(save-excursion
(set-buffer gnus-agent-current-history)
(gnus-make-directory (file-name-directory gnus-agent-file-name))
! (write-region (1+ (point-min)) (point-max)
! gnus-agent-file-name nil 'silent)))
(defun gnus-agent-close-history ()
(when (gnus-buffer-live-p gnus-agent-current-history)
--- 605,613 ----
(save-excursion
(set-buffer gnus-agent-current-history)
(gnus-make-directory (file-name-directory gnus-agent-file-name))
! (let ((coding-system-for-write gnus-agent-file-coding-system))
! (write-region (1+ (point-min)) (point-max)
! gnus-agent-file-name nil 'silent))))
(defun gnus-agent-close-history ()
(when (gnus-buffer-live-p gnus-agent-current-history)
***************
*** 703,709 ****
(setq id "No-Message-ID-in-article")
(setq id (buffer-substring (match-beginning 1) (match-end 1))))
(let ((coding-system-for-write
! gnus-agent-article-file-coding-system))
(write-region (point-min) (point-max)
(concat dir (number-to-string (caar pos)))
nil 'silent))
--- 705,711 ----
(setq id "No-Message-ID-in-article")
(setq id (buffer-substring (match-beginning 1) (match-end 1))))
(let ((coding-system-for-write
! gnus-agent-file-coding-system))
(write-region (point-min) (point-max)
(concat dir (number-to-string (caar pos)))
nil 'silent))
***************
*** 746,755 ****
(save-excursion
(while gnus-agent-buffer-alist
(set-buffer (cdar gnus-agent-buffer-alist))
! (write-region (point-min) (point-max)
! (gnus-agent-article-name ".overview"
! (caar gnus-agent-buffer-alist))
! nil 'silent)
(pop gnus-agent-buffer-alist))
(while gnus-agent-group-alist
(with-temp-file (caar gnus-agent-group-alist)
--- 748,759 ----
(save-excursion
(while gnus-agent-buffer-alist
(set-buffer (cdar gnus-agent-buffer-alist))
! (let ((coding-system-for-write
! gnus-agent-file-coding-system))
! (write-region (point-min) (point-max)
! (gnus-agent-article-name ".overview"
! (caar gnus-agent-buffer-alist))
! nil 'silent))
(pop gnus-agent-buffer-alist))
(while gnus-agent-group-alist
(with-temp-file (caar gnus-agent-group-alist)
***************
*** 780,786 ****
(gnus-agent-braid-nov group articles file))
(gnus-make-directory (nnheader-translate-file-chars
(file-name-directory file)))
! (write-region (point-min) (point-max) file nil 'silent)
(gnus-agent-save-alist group articles nil)
(gnus-agent-enter-history
"last-header-fetched-for-session"
--- 784,792 ----
(gnus-agent-braid-nov group articles file))
(gnus-make-directory (nnheader-translate-file-chars
(file-name-directory file)))
! (let ((coding-system-for-write
! gnus-agent-file-coding-system))
! (write-region (point-min) (point-max) file nil 'silent))
(gnus-agent-save-alist group articles nil)
(gnus-agent-enter-history
"last-header-fetched-for-session"
***************
*** 1386,1392 ****
;; Schedule the history line for nuking.
(push (cdr elem) histories)))
(gnus-make-directory (file-name-directory nov-file))
! (write-region (point-min) (point-max) nov-file nil 'silent)
;; Delete the unwanted entries in the alist.
(setq gnus-agent-article-alist
(sort gnus-agent-article-alist 'car-less-than-car))
--- 1392,1400 ----
;; Schedule the history line for nuking.
(push (cdr elem) histories)))
(gnus-make-directory (file-name-directory nov-file))
! (let ((coding-system-for-write
! gnus-agent-file-coding-system))
! (write-region (point-min) (point-max) nov-file nil 'silent))
;; Delete the unwanted entries in the alist.
(setq gnus-agent-article-alist
(sort gnus-agent-article-alist 'car-less-than-car))
*** nnmh.el.orig Wed Sep 16 13:06:14 1998
--- nnmh.el Wed Sep 16 13:19:32 1998
***************
*** 294,300 ****
(deffoo nnmh-request-accept-article (group &optional server last noinsert)
(nnmh-possibly-change-directory group server)
! (nnmail-check-syntax)
(when nnmail-cache-accepted-message-ids
(nnmail-cache-insert (nnmail-fetch-field "message-id")))
(nnheader-init-server-buffer)
--- 294,301 ----
(deffoo nnmh-request-accept-article (group &optional server last noinsert)
(nnmh-possibly-change-directory group server)
! (if (not (string-equal group "queue"))
! (nnmail-check-syntax))
(when nnmail-cache-accepted-message-ids
(nnmail-cache-insert (nnmail-fetch-field "message-id")))
(nnheader-init-server-buffer)
[-- Attachment #3: Type: text/plain, Size: 106 bytes --]
--
Tatsuya Ichikawa <ichikawa@hv.epson.co.jp>
# PGP Public Key : See X-Info header in this message.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Invalid message-id header when unplugged.
1998-09-16 4:20 Invalid message-id header when unplugged Tatsuya Ichikawa
@ 1998-09-16 7:32 ` Graham Murray
1998-09-16 8:02 ` Tatsuya Ichikawa
1998-09-16 9:45 ` Lars Magne Ingebrigtsen
1 sibling, 1 reply; 4+ messages in thread
From: Graham Murray @ 1998-09-16 7:32 UTC (permalink / raw)
Tatsuya Ichikawa <ichikawa@hv.epson.co.jp> writes:
> When gnus is unplugged status , nnmail-check-syntax insert
> Message-ID header like this.
>
> Message-ID: <86emtfltdv.fsf@totally-fudged-out-message-id>
>
> ;; Message-ID is not member of message-required-news-headers.
> ;; In this case , I want to add Message-ID header by ISP news server.
>
> In plugged status gnus-agent-send-drafts typing "JS" in group
> buffer, Message-ID header is still above line.
>
> Is that right ??
That looks right to me. I have tested (using gnus 5.6.43) sending a
message from gnus when unplugged and the message-id is *exactly* the
same format as when I use gnus in non-agent mode.
So, Lars, please may I request that you do *not* apply this patch and
leave the message-id generation as it is.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Invalid message-id header when unplugged.
1998-09-16 7:32 ` Graham Murray
@ 1998-09-16 8:02 ` Tatsuya Ichikawa
0 siblings, 0 replies; 4+ messages in thread
From: Tatsuya Ichikawa @ 1998-09-16 8:02 UTC (permalink / raw)
>>>>> In <graham7lz4ikcc.fsf@barnowl.demon.co.uk>
>>>>> Graham Murray <graham@barnowl.demon.co.uk> wrote:
Graham> That looks right to me. I have tested (using gnus 5.6.43)
Graham> sending a message from gnus when unplugged and the message-id
Graham> is *exactly* the same format as when I use gnus in non-agent
Graham> mode.
You might have tested in message-requrired-news-headers's value like
following.
message-required-news-headers's value is
(From Newsgroups Subject Date Message-ID
(optional . Organization)
Lines
(optional . User-Agent))
But I have tested in message-required-news-headers's value like
following.
message-required-news-headers's value is
(From Newsgroups Subject Date
(optional . Organization)
Lines
(optional . User-Agent))
Message-ID header in news message must be unique all around the
world.
So , unplugged-gnus must not add message-id header.
ISP's news server add it like this environment.
Graham> So, Lars, please may I request that you do *not* apply this
Graham> patch and leave the message-id generation as it is.
So this patch may need , I think.
Thanks.
--
Tatsuya Ichikawa <ichikawa@hv.epson.co.jp>
# PGP Public Key : See X-Info header in this message.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Invalid message-id header when unplugged.
1998-09-16 4:20 Invalid message-id header when unplugged Tatsuya Ichikawa
1998-09-16 7:32 ` Graham Murray
@ 1998-09-16 9:45 ` Lars Magne Ingebrigtsen
1 sibling, 0 replies; 4+ messages in thread
From: Lars Magne Ingebrigtsen @ 1998-09-16 9:45 UTC (permalink / raw)
Tatsuya Ichikawa <ichikawa@hv.epson.co.jp> writes:
> When gnus is unplugged status , nnmail-check-syntax insert
> Message-ID header like this.
>
> Message-ID: <86emtfltdv.fsf@totally-fudged-out-message-id>
>
> ;; Message-ID is not member of message-required-news-headers.
> ;; In this case , I want to add Message-ID header by ISP news server.
Well -- the problem here is that you want your ISP to generate the
Message-ID. This is not a good idea. For instance, if you send a
combined message (a message with both a Cc and a Newsgroups header),
the two copies will have differing Message-ID's, which is
non-compliant with the drafts for the RFC for combined messages.
So I think you should put Message-ID back into
message-required-news-headers.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~1998-09-16 9:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1998-09-16 4:20 Invalid message-id header when unplugged Tatsuya Ichikawa
1998-09-16 7:32 ` Graham Murray
1998-09-16 8:02 ` Tatsuya Ichikawa
1998-09-16 9:45 ` Lars Magne Ingebrigtsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).