Spurious line inserted if mm-uu-hide-markers is nil

Spurious line inserted if mm-uu-hide-markers is nil

[Ralf Angeli]

Hi,

if you set `mm-uu-hide-markers' to nil as to not lose stuff like
verbatim marks when replying to a message, then a spurious empty line is
inserted in front of a region marked with `message-mark-inserted-region'
such as this:

--8<---------------cut here---------------start------------->8---
foo
--8<---------------cut here---------------end--------------->8---

The empty line is fontified with the face `mm-uu-extract'.

The issue goes away if you apply the following patch:

--- lisp/gnus/mm-uu.el	2010-09-02 01:42:32 +0000
+++ lisp/gnus/mm-uu.el	2010-11-20 20:36:07 +0000
@@ -165,7 +165,7 @@
      ;; dependency on `message.el'.
      "^-+[8<>]*-\\{9,\\}[a-z ]+-\\{9,\\}[a-z ]+-\\{9,\\}[8<>]*-+$"
      "^-+[8<>]*-\\{9,\\}[a-z ]+-\\{9,\\}[a-z ]+-\\{9,\\}[8<>]*-+$"
-     (lambda () (mm-uu-verbatim-marks-extract -1 0 1 -1))
+     (lambda () (mm-uu-verbatim-marks-extract 0 0 1 -1))
      nil)
     ;; Omitting [a-z8<] leads to false positives (bogus signature separators
     ;; and mailing list banners).


Does anybody know if the -1 for the `start-offset' parameter of
`mm-uu-verbatim-marks-extract' has been used on purpose, i.e. would the
change have any negative effects?  If not and if there are no
objections, I'd apply it in Emacs' Bazaar repository.

-- 
Ralf

Re: Spurious line inserted if mm-uu-hide-markers is nil

[Lars Magne Ingebrigtsen]

Ralf Angeli <angeli@caeruleus.net> writes:

> if you set `mm-uu-hide-markers' to nil as to not lose stuff like
> verbatim marks when replying to a message, then a spurious empty line is
> inserted in front of a region marked with `message-mark-inserted-region'
> such as this:
> --8<---------------cut here---------------start------------->8---
> foo
> --8<---------------cut here---------------end--------------->8---
> The empty line is fontified with the face `mm-uu-extract'.

Where is the empty line inserted?  I set `mm-uu-hide-markers' to nil,
and I can't really see any empty lines anywhere...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Spurious line inserted if mm-uu-hide-markers is nil

[Ralf Angeli]

* Lars Magne Ingebrigtsen (2010-11-21) writes:

> Ralf Angeli <angeli@caeruleus.net> writes:
>
>> if you set `mm-uu-hide-markers' to nil as to not lose stuff like
>> verbatim marks when replying to a message, then a spurious empty line is
>> inserted in front of a region marked with `message-mark-inserted-region'
>> such as this:
>> --8<---------------cut here---------------start------------->8---
>> foo
>> --8<---------------cut here---------------end--------------->8---
>> The empty line is fontified with the face `mm-uu-extract'.
>
> Where is the empty line inserted?  I set `mm-uu-hide-markers' to nil,
> and I can't really see any empty lines anywhere...

Right above the upper verbatim mark.  So here it looks like this:
| 
| 
| --8<---------------cut here---------------start------------->8---
| foo
| --8<---------------cut here---------------end--------------->8---
| 
When I wrote the original article there was one empty line above the
upper verbatim mark and one below the lower verbatim mark.  (In your
quote above those are suspiciously missing.)  The second one on top was
not there originally.  This happens with the current development version
of Emacs (trunk) and the version of Gnus coming with it.

-- 
Ralf

Re: Spurious line inserted if mm-uu-hide-markers is nil

[Lars Magne Ingebrigtsen]

Ralf Angeli <angeli@caeruleus.net> writes:

> When I wrote the original article there was one empty line above the
> upper verbatim mark and one below the lower verbatim mark.  (In your
> quote above those are suspiciously missing.)  The second one on top was
> not there originally. 

Ah, right.  I had a washing function that removed the extra line.

I think your fix is correct, so please apply it.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Spurious line inserted if mm-uu-hide-markers is nil

[Ralf Angeli]

* Lars Magne Ingebrigtsen (2010-11-21) writes:

> Ralf Angeli <angeli@caeruleus.net> writes:
>
>> When I wrote the original article there was one empty line above the
>> upper verbatim mark and one below the lower verbatim mark.  (In your
>> quote above those are suspiciously missing.)  The second one on top was
>> not there originally. 
>
> Ah, right.  I had a washing function that removed the extra line.
>
> I think your fix is correct, so please apply it.

Done.  Thanks for the assessment.

-- 
Ralf