From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/51932 Path: main.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.gnus.general Subject: Re: pgg passphrase caching Date: Tue, 29 Apr 2003 02:45:43 +0200 Sender: ding-owner@lists.math.uh.edu Message-ID: References: <86fzo3g2v7.fsf@jochen.rijnh.nl> <86wuhejji1.fsf@jochen.rijnh.nl> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: main.gmane.org 1051577110 10670 80.91.224.249 (29 Apr 2003 00:45:10 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 29 Apr 2003 00:45:10 +0000 (UTC) Cc: ding@gnus.org Original-X-From: ding-owner+M475@lists.math.uh.edu Tue Apr 29 02:45:07 2003 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19AJF5-0002lt-00 for ; Tue, 29 Apr 2003 02:45:07 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 19AJFo-00044N-00; Mon, 28 Apr 2003 19:45:52 -0500 Original-Received: from sclp3.sclp.com ([64.157.176.121]) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 19AJFj-00044I-00 for ding@lists.math.uh.edu; Mon, 28 Apr 2003 19:45:47 -0500 Original-Received: (qmail 63949 invoked by alias); 29 Apr 2003 00:45:47 -0000 Original-Received: (qmail 63944 invoked from network); 29 Apr 2003 00:45:47 -0000 Original-Received: from 178.230.13.217.in-addr.dgcsystems.net (HELO yxa.extundo.com) (217.13.230.178) by sclp3.sclp.com with SMTP; 29 Apr 2003 00:45:47 -0000 Original-Received: from latte.josefsson.org (yxa.extundo.com [217.13.230.178]) (authenticated bits=0) by yxa.extundo.com (8.12.9/8.12.9) with ESMTP id h3T0jibU006203 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Tue, 29 Apr 2003 02:45:44 +0200 Original-To: jochen@jochen-kuepper.de Mail-Copies-To: nobody X-Payment: hashcash 1.2 0:030429:jochen@jochen-kuepper.de:42721b840fc44baa X-Hashcash: 0:030429:jochen@jochen-kuepper.de:42721b840fc44baa X-Payment: hashcash 1.2 0:030429:ding@gnus.org:fb8e529bd1eee70d X-Hashcash: 0:030429:ding@gnus.org:fb8e529bd1eee70d In-Reply-To: <86wuhejji1.fsf@jochen.rijnh.nl> (Jochen =?iso-8859-1?q?K=FCpper's?= message of "Tue, 29 Apr 2003 01:21:42 +0200") User-Agent: Gnus/5.09002 (Oort Gnus v0.20) Emacs/21.3.50 (gnu/linux) Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:51932 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:51932 Jochen Küpper writes: > The problem was introduced between cvs' -D 20030416 and 20030417. Thanks, it is the pgg-default-user-id addition to mml2015.el that caused the problem: (defun mml2015-pgg-sign (cont) (let ((pgg-errors-buffer mml2015-result-buffer) (boundary (funcall mml-boundary-function (incf mml-multipart-number))) (pgg-default-user-id (or (message-options-get 'message-sender) pgg-default-user-id))) ... The problem is that (message-options-get 'message-sender) always return something, where we'd really only want it to return something if the user specified a MML sender=0xfoobar tag. Please upgrade to HEAD to try the following patch. 2003-04-29 Simon Josefsson * mml2015.el (mml2015-pgg-sign): Use mml-sender instead of message-sender. * mml.el (mml-generate-mime-1): Set mml-sender too. --- mml.el.~6.74.~ Sun Apr 27 17:01:37 2003 +++ mml.el Tue Apr 29 02:43:15 2003 @@ -541,7 +541,8 @@ mml-encrypt-alist)) sender recipients) (when (or sign-item encrypt-item) - (if (setq sender (cdr (assq 'sender cont))) + (when (setq sender (cdr (assq 'sender cont))) + (message-options-set 'mml-sender sender) (message-options-set 'message-sender sender)) (if (setq recipients (cdr (assq 'recipients cont))) (message-options-set 'message-recipients recipients)) --- mml2015.el.~6.60.~ Wed Apr 16 21:19:32 2003 +++ mml2015.el Tue Apr 29 02:43:28 2003 @@ -807,7 +807,7 @@ (defun mml2015-pgg-sign (cont) (let ((pgg-errors-buffer mml2015-result-buffer) (boundary (funcall mml-boundary-function (incf mml-multipart-number))) - (pgg-default-user-id (or (message-options-get 'message-sender) + (pgg-default-user-id (or (message-options-get 'mml-sender) pgg-default-user-id))) (unless (pgg-sign-region (point-min) (point-max)) (pop-to-buffer mml2015-result-buffer)