Gnus development mailing list
 help / color / mirror / Atom feed
From: Simon Josefsson <jas@extundo.com>
Cc: ding@gnus.org, xemacs-patches@xemacs.org
Subject: Re: [COMMIT PATCH PACKAGES(ecrypto)] Sync with Gnus
Date: Tue, 16 Dec 2003 02:00:12 +0100	[thread overview]
Message-ID: <ilu3cblvaoz.fsf@latte.josefsson.org> (raw)
In-Reply-To: <b9y7k0xbpxb.fsf@jpl.org> (Katsumi Yamaoka's message of "Tue, 16 Dec 2003 08:51:28 +0900")

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> I noticed that change requires cl at the run-time (in FSFmacs).
> It is because arguments in defcustom forms aren't expanded or
> byte-compiled.  It is better to replace ignore-errors with
> condition-case.

Yup.  I have installed this, please verify that it works.  Sorry for
the trouble.

2003-12-16  Simon Josefsson  <jas@extundo.com>

	* sha1-el.el (autoload): Don't use ignore-errors.
	(sha1-use-external): Use condition-case.  Suggested by Katsumi
	Yamaoka <yamaoka@jpl.org>.

Index: sha1-el.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/ecrypto/sha1-el.el,v
retrieving revision 1.3
diff -u -p -r1.3 sha1-el.el
--- sha1-el.el  15 Dec 2003 01:36:40 -0000      1.3
+++ sha1-el.el  16 Dec 2003 00:58:30 -0000
@@ -54,7 +54,7 @@
  
 (require 'hex-util)
  
-(ignore-errors (autoload 'executable-find "executable"))
+(autoload 'executable-find "executable")
  
 ;;;
 ;;; external SHA1 function.
@@ -79,8 +79,9 @@ It must be a string \(program name\) or
   :type '(repeat string)
   :group 'sha1)
  
-(defcustom sha1-use-external (ignore-errors
-                              (executable-find (car sha1-program)))
+(defcustom sha1-use-external (condition-case ()
+                                (executable-find (car sha1-program))
+                              (error))
   "*Use external SHA1 program.
 If this variable is set to nil, use internal function only."
   :type 'boolean




      reply	other threads:[~2003-12-16  1:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <iluad5uvprm.fsf@latte.josefsson.org>
     [not found] ` <iluznduual9.fsf@latte.josefsson.org>
2003-12-15 23:51   ` Katsumi Yamaoka
2003-12-16  1:00     ` Simon Josefsson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ilu3cblvaoz.fsf@latte.josefsson.org \
    --to=jas@extundo.com \
    --cc=ding@gnus.org \
    --cc=xemacs-patches@xemacs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).