From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/55240 Path: main.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.gnus.general,gmane.emacs.xemacs.patches Subject: Re: [COMMIT PATCH PACKAGES(ecrypto)] Sync with Gnus Date: Tue, 16 Dec 2003 02:00:12 +0100 Sender: ding-owner@lists.math.uh.edu Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1071536455 3745 80.91.224.253 (16 Dec 2003 01:00:55 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 16 Dec 2003 01:00:55 +0000 (UTC) Cc: ding@gnus.org, xemacs-patches@xemacs.org Original-X-From: ding-owner+M3780@lists.math.uh.edu Tue Dec 16 02:00:52 2003 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AW3a0-0001KE-00 for ; Tue, 16 Dec 2003 02:00:52 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1AW3Zc-0006jQ-00; Mon, 15 Dec 2003 19:00:28 -0600 Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1AW3ZY-0006jL-00 for ding@lists.math.uh.edu; Mon, 15 Dec 2003 19:00:24 -0600 Original-Received: from yxa.extundo.com (178.230.13.217.in-addr.dgcsystems.net [217.13.230.178]) by justine.libertine.org (Postfix) with ESMTP id 036763A0026 for ; Mon, 15 Dec 2003 19:00:23 -0600 (CST) Original-Received: from latte.josefsson.org (yxa.extundo.com [217.13.230.178]) (authenticated bits=0) by yxa.extundo.com (8.12.10/8.12.10) with ESMTP id hBG10LAU017529 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Tue, 16 Dec 2003 02:00:21 +0100 Original-To: Katsumi Yamaoka X-Payment: hashcash 1.2 0:031216:yamaoka@jpl.org:15d4f8527b8f0367 X-Hashcash: 0:031216:yamaoka@jpl.org:15d4f8527b8f0367 X-Payment: hashcash 1.2 0:031216:ding@gnus.org:799cf7e8f9165d80 X-Hashcash: 0:031216:ding@gnus.org:799cf7e8f9165d80 X-Payment: hashcash 1.2 0:031216:xemacs-patches@xemacs.org:2a36b9111441aa50 X-Hashcash: 0:031216:xemacs-patches@xemacs.org:2a36b9111441aa50 In-Reply-To: (Katsumi Yamaoka's message of "Tue, 16 Dec 2003 08:51:28 +0900") User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (gnu/linux) Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:55240 gmane.emacs.xemacs.patches:3640 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:55240 Katsumi Yamaoka writes: > I noticed that change requires cl at the run-time (in FSFmacs). > It is because arguments in defcustom forms aren't expanded or > byte-compiled. It is better to replace ignore-errors with > condition-case. Yup. I have installed this, please verify that it works. Sorry for the trouble. 2003-12-16 Simon Josefsson * sha1-el.el (autoload): Don't use ignore-errors. (sha1-use-external): Use condition-case. Suggested by Katsumi Yamaoka . Index: sha1-el.el =================================================================== RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/ecrypto/sha1-el.el,v retrieving revision 1.3 diff -u -p -r1.3 sha1-el.el --- sha1-el.el 15 Dec 2003 01:36:40 -0000 1.3 +++ sha1-el.el 16 Dec 2003 00:58:30 -0000 @@ -54,7 +54,7 @@ (require 'hex-util) -(ignore-errors (autoload 'executable-find "executable")) +(autoload 'executable-find "executable") ;;; ;;; external SHA1 function. @@ -79,8 +79,9 @@ It must be a string \(program name\) or :type '(repeat string) :group 'sha1) -(defcustom sha1-use-external (ignore-errors - (executable-find (car sha1-program))) +(defcustom sha1-use-external (condition-case () + (executable-find (car sha1-program)) + (error)) "*Use external SHA1 program. If this variable is set to nil, use internal function only." :type 'boolean