Re: widening in nnml split does not work

[Simon Josefsson <jas@extundo.com>]

kai.grossjohann@uni-duisburg.de (Kai Großjohann) writes:

> Ted Zlatanov <tzz@lifelogs.com> writes:
>
>> OK, but it doesn't.  (widen) just gives me the headers of the
>> message.
>>
>> This is incorrect behavior according to the manual, so I'd say it's a
>> legitimate bug.  Yay.
>
> Well, I've now looked at the code.  It seems it's intentional, and
> not easy to fix.  Here is how it goes:
>
> nnmail-process-unix-mail-format calls nnmail-check-duplication on
> each message.  That function calls nnmail-article-group, which copies
> the headers to a temp buffer and does some MIMEy decoding on them
> before doing the splitting dance.
>
> So I'm afraid that maybe the manual needs to be fixed, rather than
> the code.
>
> Or nnmail-article-group could be augmented to optionally do some work
> on the body, too.
>
> Hm.  Sounds like real work.

Augmenting n-a-g doesn't sound too hard.  Wouldn't something like the
following work?

--- nnmail.el.~6.57.~	Sun Jan 19 11:31:14 2003
+++ nnmail.el	Sat Jan 25 15:47:38 2003
@@ -998,8 +998,7 @@
 FUNC will be called with the group name to determine the article number."
   (let ((methods (or nnmail-split-methods '(("bogus" ""))))
 	(obuf (current-buffer))
-	(beg (point-min))
-	end group-art method grp)
+	group-art method grp)
     (if (and (sequencep methods)
 	     (= (length methods) 1))
 	;; If there is only just one group to put everything in, we
@@ -1008,13 +1007,12 @@
 	      (list (cons (caar methods) (funcall func (caar methods)))))
       ;; We do actual comparison.
       (save-excursion
-	;; Find headers.
-	(goto-char beg)
-	(setq end (if (search-forward "\n\n" nil t) (point) (point-max)))
+	;; Copy the article into the work buffer.
 	(set-buffer nntp-server-buffer)
 	(erase-buffer)
-	;; Copy the headers into the work buffer.
-	(insert-buffer-substring obuf beg end)
+	(insert-buffer obuf)
+	;; Narrow to headers.
+	(mail-narrow-to-head)
 	;; Decode MIME headers and charsets.
 	(when nnmail-mail-splitting-decodes
 	  (let ((mail-parse-charset nnmail-mail-splitting-charset))
@@ -1115,7 +1113,8 @@
 	  (let (elem)
 	    (while (setq elem (car (memq 'junk group-art)))
 	      (setq group-art (delq elem group-art)))
-	    (nreverse group-art)))))))
+	    (nreverse group-art))))
+      (widen))))
 
 (defun nnmail-insert-lines ()
   "Insert how many lines there are in the body of the mail.