Gnus development mailing list
 help / color / mirror / Atom feed
From: Simon Josefsson <jas@extundo.com>
Cc: ding@gnus.org
Subject: Re: "> > >" space removal removes too many spaces?
Date: Sun, 05 Aug 2001 15:03:36 +0200	[thread overview]
Message-ID: <ilu7kwifyl3.fsf@barbar.josefsson.org> (raw)
In-Reply-To: <vafu1zmu3hm.fsf@INBOX.auto.gnus.tok.lucy.cs.uni-dortmund.de> (Kai.Grossjohann@CS.Uni-Dortmund.DE's message of "Sun, 05 Aug 2001 13:53:57 +0200")

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> Look at this:
> 
> % ftp
> ftp> open host
> ftp> quit
> % date
> 
> If you hit `F' or `R' on this message you will see that some lines are
> quoted like "> % ftp" whereas other lines are quoted like ">ftp> quit".
> Note how a space is missing in the `ftp>' lines.
> 
> Is this a bug?

I think so; `message-yank-cited-prefix' (">") should probably only be
used if the original article used the "correct" quotation style.
Right now `message-cite-prefix-regexp' is used to match quoted lines,
but that regexp matches lots of weird styles, and there might exist
uglier missmatches than this.

Also, consider the following style as well:

,----
| Kai> Hm.  The agent.  Hm.  I have (gnus-agentize) in my .gnus and the
| Kai> server is under the agent, but I'm always plugged.
| 
| If plugged, it shouldn't matter then as it shouldn't be talking to the
| agent (AFAIK).
`----

When quoting that, I think

,----
| > Kai> Hm.  The agent.  Hm.  I have (gnus-agentize) in my .gnus and the
| > Kai> server is under the agent, but I'm always plugged.
| > 
| > If plugged, it shouldn't matter then as it shouldn't be talking to the
| > agent (AFAIK).
`----

looks nicer than

,----
| >Kai> Hm.  The agent.  Hm.  I have (gnus-agentize) in my .gnus and the
| >Kai> server is under the agent, but I'm always plugged.
| > 
| > If plugged, it shouldn't matter then as it shouldn't be talking to the
| > agent (AFAIK).
`----

Perhaps.

So, maybe the following?  Maybe it shouldn't match ">From"?  And maybe
it shouldn't be hardcoded.  Or maybe, both that string and
`message-yank-{cited-,}prefix' really _should_ be hardcoded (users
should not really change them).  Perhaps it's enough that these
variables aren't documented.

--- message.el.~6.108.~	Sat Jul 28 19:01:54 2001
+++ message.el	Sun Aug  5 14:43:53 2001
@@ -2101,7 +2101,7 @@
       (save-excursion
 	(goto-char start)
 	(while (< (point) (mark t))
-	  (if (looking-at message-cite-prefix-regexp)
+	  (if (looking-at ">")
 	      (insert message-yank-cited-prefix)
 	    (insert message-yank-prefix))
 	  (forward-line 1))))



  parent reply	other threads:[~2001-08-05 13:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-05 11:53 Kai Großjohann
2001-08-05 12:05 ` Norbert Koch
2001-08-05 12:15   ` Kai Großjohann
2001-08-05 12:23     ` Norbert Koch
2001-08-05 13:03 ` Simon Josefsson [this message]
2001-08-05 13:10   ` Simon Josefsson
2001-08-05 13:46   ` Florian Weimer
2001-08-05 13:57     ` Simon Josefsson
2001-08-05 14:24       ` Nuutti Kotivuori
2001-08-05 14:49         ` Florian Weimer
2001-08-05 21:23           ` Nuutti Kotivuori
2001-08-05 14:47       ` Florian Weimer
2001-08-05 17:25         ` Kai Großjohann
2001-08-05 17:55           ` Florian Weimer
2001-08-05 19:30         ` Simon Josefsson
2001-08-05 20:11           ` Florian Weimer
2001-08-05 20:45             ` Kai Großjohann
2001-08-05 20:08         ` Kai Großjohann
2001-08-05 23:11   ` Paul Jarc
2001-08-06  6:33     ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ilu7kwifyl3.fsf@barbar.josefsson.org \
    --to=jas@extundo.com \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).