Gnus development mailing list
 help / color / mirror / Atom feed
From: Simon Josefsson <jas@extundo.com>
Cc: ding@gnus.org
Subject: Re: gnus-union needs a lot of time
Date: Thu, 29 Nov 2001 16:43:04 +0100	[thread overview]
Message-ID: <ilubshleg6v.fsf@dhcp128.extundo.com> (raw)
In-Reply-To: <m3pu62f1p2.fsf@ID-24456.user.dfncis.de> (Christoph Conrad's message of "Thu, 29 Nov 2001 08:58:33 +0100")

Christoph Conrad <christoph.conrad@gmx.de> writes:

> Hi,
>
> downloading articles with the Gnus agent did spent longer and longer
> in the last months, even when there are no articles to download. I
> made an M-x elp-instrument-package <RET> gnus- <RET> and got the
> following results (excerpt):
>
> gnus-agent-fetch-headers 11 44.600695     4.0546086363
> gnus-union               68 41.160040000  0.6052947058
>
> Over 90% of the time is spent in gnus-union, which in fact is an alias
> to 'union on my computer.
>
> I am wondering if there is a possibility to speed up this function or
> the information which is processed here?

I guess so.  Does this patch help?  Maybe you could try using
`gnus-add-to-range' instead if this doesn't improve it too much.  New
elp results would be interesting.

Index: gnus-agent.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-agent.el,v
retrieving revision 6.25
diff -u -u -w -r6.25 gnus-agent.el
--- gnus-agent.el	2001/11/21 06:24:47	6.25
+++ gnus-agent.el	2001/11/29 15:43:30
@@ -999,9 +999,8 @@
 	(file (gnus-agent-article-name ".overview" group)))
     ;; Add article with marks to list of article headers we want to fetch.
     (dolist (arts (gnus-info-marks (gnus-get-info group)))
-      (setq articles (gnus-union (gnus-uncompress-sequence (cdr arts))
-			    articles)))
-    (setq articles (sort articles '<))
+      (setq articles (gnus-range-add articles (cdr arts))))
+    (setq articles (sort (gnus-uncompress-sequence articles) '<))
     ;; Remove known articles.
     (when (gnus-agent-load-alist group)
       (setq articles (gnus-sorted-intersection




  reply	other threads:[~2001-11-29 15:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-29  7:58 Christoph Conrad
2001-11-29 15:43 ` Simon Josefsson [this message]
2001-11-29 22:22   ` Christoph Conrad
2001-11-29 23:09     ` Simon Josefsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ilubshleg6v.fsf@dhcp128.extundo.com \
    --to=jas@extundo.com \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).