Gnus development mailing list
 help / color / mirror / Atom feed
* error entering cvs gnus
@ 2001-08-18 23:49 Laura Conrad
  2001-08-19  0:11 ` Simon Josefsson
  0 siblings, 1 reply; 6+ messages in thread
From: Laura Conrad @ 2001-08-18 23:49 UTC (permalink / raw)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

When I try to enter the cvs gnus that I upped this afternoon, I get:

Signaling: (file-error "Creating directory" "file exists" "/home/lconrad/Mail/world/old")
  make-directory-internal("/home/lconrad/Mail/world/old")
  make-directory("/home/lconrad/Mail/world/old/" t)
  gnus-make-directory("/home/lconrad/Mail/world/old/")
  nnml-save-marks("world.old" "private")
  nnml-open-marks("world.old" "private")
  nnml-request-update-info("world.old" ("nnml+private:world.old" 6 (6106 6662 6881) nil "nnml:private") "private")
  gnus-get-unread-articles(nil)
  gnus-setup-news(nil nil nil)
  byte-code("\b„\x0e
  gnus-1(nil nil nil)
  gnus()
  command-line-1(("-f" "gnus"))
  command-line()
  normal-top-level()

-- 
Laura (mailto:lconrad@laymusic.org , http://www.laymusic.org/ )
(617) 661-8097	fax: (801) 365-6574 
233 Broadway, Cambridge, MA 02139


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: error entering cvs gnus
  2001-08-18 23:49 error entering cvs gnus Laura Conrad
@ 2001-08-19  0:11 ` Simon Josefsson
  2001-08-19  0:48   ` Laura Conrad
  0 siblings, 1 reply; 6+ messages in thread
From: Simon Josefsson @ 2001-08-19  0:11 UTC (permalink / raw)
  Cc: ding

Laura Conrad <lconrad@laymusic.org> writes:

> When I try to enter the cvs gnus that I upped this afternoon, I get:
>
> Signaling: (file-error "Creating directory" "file exists" "/home/lconrad/Mail/world/old")
>   make-directory-internal("/home/lconrad/Mail/world/old")
>   make-directory("/home/lconrad/Mail/world/old/" t)
>   gnus-make-directory("/home/lconrad/Mail/world/old/")

I don't get this, `gnus-make-directory' should only create the
directory if it does not already exist:

(defun gnus-make-directory (directory)
  "Make DIRECTORY (and all its parents) if it doesn't exist."
  (require 'nnmail)
  (let ((file-name-coding-system nnmail-pathname-coding-system))
    (when (and directory
	       (not (file-exists-p directory)))
      (make-directory directory t)))
  t)

Is there something wrong with `file-exists-p' in your setup?  NFS?
Does `(file-exists-p "/home/lconrad/Mail/world/old/")' really evaluate
to nil?  The directory exists, right?

Maybe `file-directory-p' should be used instead?



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: error entering cvs gnus
  2001-08-19  0:11 ` Simon Josefsson
@ 2001-08-19  0:48   ` Laura Conrad
  2001-08-19  8:58     ` Simon Josefsson
  0 siblings, 1 reply; 6+ messages in thread
From: Laura Conrad @ 2001-08-19  0:48 UTC (permalink / raw)


>>>>> "Simon" == Simon Josefsson <jas@extundo.com> writes:

    Simon> Laura Conrad <lconrad@laymusic.org> writes:
    >> When I try to enter the cvs gnus that I upped this afternoon, I
    >> get:
    >> 
    >> Signaling: (file-error "Creating directory" "file exists"
    >> "/home/lconrad/Mail/world/old")

    Simon> The directory exists, right?

No.  I was going to post a followup.  That directory is (was) a link to a
directory that used to exist before I rearranged all my partitions.
It exists now, and I can use the CVS gnus.  Which is good because it
does several good things that the latest ognus release doesn't.  But
I'm probably not the only person in the world who rearranges
partitions and doesn't fix all the links to the old partitions.  And
gnus never complained about this before today.


-- 
Laura (mailto:lconrad@laymusic.org , http://www.laymusic.org/ )
(617) 661-8097	fax: (801) 365-6574 
233 Broadway, Cambridge, MA 02139


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: error entering cvs gnus
  2001-08-19  0:48   ` Laura Conrad
@ 2001-08-19  8:58     ` Simon Josefsson
  2001-08-19 11:22       ` Laura Conrad
  0 siblings, 1 reply; 6+ messages in thread
From: Simon Josefsson @ 2001-08-19  8:58 UTC (permalink / raw)
  Cc: ding

Laura Conrad <lconrad@laymusic.org> writes:

>     >> When I try to enter the cvs gnus that I upped this afternoon, I
>     >> get:
>     >> 
>     >> Signaling: (file-error "Creating directory" "file exists"
>     >> "/home/lconrad/Mail/world/old")
>
>     Simon> The directory exists, right?
>
> No.  I was going to post a followup.  That directory is (was) a link to a
> directory that used to exist before I rearranged all my partitions.
> It exists now, and I can use the CVS gnus.  Which is good because it
> does several good things that the latest ognus release doesn't.  But
> I'm probably not the only person in the world who rearranges
> partitions and doesn't fix all the links to the old partitions.  And
> gnus never complained about this before today.

So the error message was correct?

Hm, what would Gnus do other than to complain?  As I see it, the
directory where a nnml group lives must exist in order to write things
into it.  If it doesn't exist, Gnus tries to create it.  I suspect the
reason you haven't received the error message before is that you
didn't write to the group (i.e. deleted or inserted articles).  Would
that be right?

I don't think there's a bug here.



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: error entering cvs gnus
  2001-08-19  8:58     ` Simon Josefsson
@ 2001-08-19 11:22       ` Laura Conrad
  2001-08-19 12:00         ` Simon Josefsson
  0 siblings, 1 reply; 6+ messages in thread
From: Laura Conrad @ 2001-08-19 11:22 UTC (permalink / raw)


>>>>> "Simon" == Simon Josefsson <jas@extundo.com> writes:

    Simon> Laura Conrad <lconrad@laymusic.org> writes:
    >> >> When I try to enter the cvs gnus that I upped this
    >> afternoon, I >> get:
    >> >> 
    >> >> Signaling: (file-error "Creating directory" "file exists" >>
    >> "/home/lconrad/Mail/world/old")

    Simon> So the error message was correct?

The error message may have been correct, but gnus should have
recovered from it and let me in anyway.  My complaint was that I
couldn't run gnus at all.

    Simon> Hm, what would Gnus do other than to complain?  

Let me read my other groups.

    Simon> As I see it, the directory where a nnml group lives must
    Simon> exist in order to write things into it.  If it doesn't
    Simon> exist, Gnus tries to create it.  I suspect the reason you
    Simon> haven't received the error message before is that you
    Simon> didn't write to the group (i.e. deleted or inserted
    Simon> articles).  Would that be right?

This isn't a group that mail gets sorted into; it's the archive group
that mail from another group gets expired into.  So I don't see why
gnus should be trying to write to it on entry.

    Simon> I don't think there's a bug here.

I disagree; no matter what damn fool thing the user has done she
should still be able to get into gnus.

-- 
Laura (mailto:lconrad@laymusic.org , http://www.laymusic.org/ )
(617) 661-8097	fax: (801) 365-6574 
233 Broadway, Cambridge, MA 02139


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: error entering cvs gnus
  2001-08-19 11:22       ` Laura Conrad
@ 2001-08-19 12:00         ` Simon Josefsson
  0 siblings, 0 replies; 6+ messages in thread
From: Simon Josefsson @ 2001-08-19 12:00 UTC (permalink / raw)
  Cc: ding

Laura Conrad <lconrad@laymusic.org> writes:

> The error message may have been correct, but gnus should have
> recovered from it and let me in anyway.  My complaint was that I
> couldn't run gnus at all.

I see.  Please try attached patch, it will ask you if Gnus should
continue even if the nnml directory is FUBAR.

> This isn't a group that mail gets sorted into; it's the archive group
> that mail from another group gets expired into.  So I don't see why
> gnus should be trying to write to it on entry.

Well, it tries to create the .marks file to make it possible to
e.g. backup the nnml server independently of .newsrc.eld.  The group
is only written to once; when you don't have a .marks file and nnml is
bootstrapping it for you.

2001-08-19  Simon Josefsson  <jas@extundo.com>

	* nnml.el (nnml-save-marks): If we can't write to marks file, ask
	user whether to continue or not.

--- nnml.el.~6.12.~	Sun Aug 19 11:38:42 2001
+++ nnml.el	Sun Aug 19 13:46:14 2001
@@ -908,11 +908,16 @@
   (let ((file-name-coding-system nnmail-pathname-coding-system)
 	(file (expand-file-name nnml-marks-file-name
 				(nnmail-group-pathname group nnml-directory))))
+    (condition-case err
+	(progn
     (nnml-possibly-create-directory group)
     (with-temp-file file
       (erase-buffer)
       (princ nnml-marks (current-buffer))
-      (insert "\n"))))
+	    (insert "\n")))
+      (error (or (gnus-yes-or-no-p
+		  (format "Could not write to %s (%s).  Continue? " file err))
+		 (error "Cannot write to %s (%s)" err))))))
 
 (defun nnml-open-marks (group server)
   (let ((file (expand-file-name 



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2001-08-19 12:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-08-18 23:49 error entering cvs gnus Laura Conrad
2001-08-19  0:11 ` Simon Josefsson
2001-08-19  0:48   ` Laura Conrad
2001-08-19  8:58     ` Simon Josefsson
2001-08-19 11:22       ` Laura Conrad
2001-08-19 12:00         ` Simon Josefsson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).