From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/55638 Path: main.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.gnus.general Subject: [PATCH] sasl, sasl-cram, sasl-digest, sasl-ntlm, hmac-def, hmac-md5 Date: Mon, 05 Jan 2004 03:13:36 +0100 Sender: ding-owner@lists.math.uh.edu Message-ID: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1073268882 25412 80.91.224.253 (5 Jan 2004 02:14:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 5 Jan 2004 02:14:42 +0000 (UTC) Cc: ding@gnus.org Original-X-From: ding-owner+M4178@lists.math.uh.edu Mon Jan 05 03:14:38 2004 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AdKGM-0004iW-00 for ; Mon, 05 Jan 2004 03:14:38 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1AdKG4-00008Z-00; Sun, 04 Jan 2004 20:14:20 -0600 Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1AdKFw-00008T-00 for ding@lists.math.uh.edu; Sun, 04 Jan 2004 20:14:12 -0600 Original-Received: from yxa.extundo.com (178.230.13.217.in-addr.dgcsystems.net [217.13.230.178]) by justine.libertine.org (Postfix) with ESMTP id DAD253A003E for ; Sun, 4 Jan 2004 20:14:10 -0600 (CST) Original-Received: from latte.josefsson.org (yxa.extundo.com [217.13.230.178]) (authenticated bits=0) by yxa.extundo.com (8.12.10/8.12.10) with ESMTP id i052DmAU012218 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Mon, 5 Jan 2004 03:13:50 +0100 Original-To: Daiki Ueno , Kenichi OKADA , Shuhei KOBAYASHI , Taro Kawagishi , emacs-mime-en@m17n.org X-Hashcash: 0:040105:ueno@unixuser.org:19d879d2cfd0e5ce X-Hashcash: 0:040105:okada@opaopa.org:4e3f2348d7822527 X-Hashcash: 0:040105:shuhei@aqua.ocn.ne.jp:deca5e28ca8acd0d X-Hashcash: 0:040105:tarok@transpulse.org:fbc06b15526e1610 X-Hashcash: 0:040105:emacs-mime-en@m17n.org:dc15239ac4efacde X-Hashcash: 0:040105:ding@gnus.org:4e5bddddb97617b7 User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:55638 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:55638 Hello, first thanks for assigning the copyright of these two files. While writing them, did anyone but you contribute to files? Have you merged patches from anyone else? According to the FLIM ChangeLog and CVS logs, only the people in To: have made non-trivial modifications to the files, and the FSF have papers for that. Can you acknowledge that this list is exhaustive? Also, after installing these files into Gnus, I made the following change to fix a byte compiler warning. Do you agree with this? If anyone is still using the DynLoad patches for Emacs, can you suggest a better fix? Thanks, Simon 2004-01-05 Simon Josefsson * hmac-md5.el (md5-binary): Fix byte compile warning. (This probably breaks emacs with DL patch, but do we care? Is anyone still using the DL stuff?) --- lisp/flim/hmac-md5.el 2001-11-03 00:01:26.000000000 +0100 +++ gnus/lisp/hmac-md5.el 2004-01-05 01:57:21.000000000 +0100 @@ -67,23 +67,14 @@ (require 'hex-util) ; (decode-hex-string STRING) (require 'md5) ; expects (md5 STRING) -;; To share *.elc files between Emacs w/ and w/o DL patch, -;; this check must be done at load-time. -(cond - ((fboundp 'md5-binary) - ;; do nothing. - ) - ((condition-case nil - ;; `md5' of v21 takes 4th arg CODING (and 5th arg NOERROR). - (md5 "" nil nil 'binary) ; => "d41d8cd98f00b204e9800998ecf8427e" - (wrong-number-of-arguments nil)) - (defun md5-binary (string) - "Return the MD5 of STRING in binary form." - (decode-hex-string (md5 string nil nil 'binary)))) - (t - (defun md5-binary (string) - "Return the MD5 of STRING in binary form." - (decode-hex-string (md5 string))))) +(defun md5-binary (string) + "Return the MD5 of STRING in binary form." + (if (condition-case nil + ;; `md5' of v21 takes 4th arg CODING (and 5th arg NOERROR). + (md5 "" nil nil 'binary) ; => "d41d8cd98f00b204e9800998ecf8427e" + (wrong-number-of-arguments nil)) + (decode-hex-string (md5 string nil nil 'binary)) + (decode-hex-string (md5 string)))) (define-hmac-function hmac-md5 md5-binary 64 16) ; => (hmac-md5 TEXT KEY) (define-hmac-function hmac-md5-96 md5-binary 64 16 96)