Re: Large *.pif base64 attachments and Gnus...

[Simon Josefsson <jas@extundo.com>]

Pavel@Janik.cz (Pavel Janík) writes:

>    From: Florian Weimer <fw@deneb.enyo.de>
>
>   > It is a bug in 'base64-decode-region'.  Perhaps it's fixed in Emacs
>   > 21, I don't know.  The base64 encoding is indeed incorrect, and that's
> 
> huh, I use 21 :-( So I will report this bug to appropriate mailing
> list. Thank you.

No, there's nothing wrong with `base64-decode-region', Gnus simply
catches the error and message it.  Does the following help?

Btw, the error with the b64 encoding is that it ends with "===", which
is invalid. Maybe the b64 parser should be made able to cope with that
simple error.

Index: mm-decode.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/mm-decode.el,v
retrieving revision 6.48
diff -u -u -w -u -w -r6.48 mm-decode.el
--- mm-decode.el	2001/08/04 00:33:18	6.48
+++ mm-decode.el	2001/08/04 23:31:56
@@ -891,20 +891,22 @@
       (if (member (mm-handle-media-supertype handle) '("text" "message"))
 	  (with-temp-buffer
 	    (insert-buffer-substring (mm-handle-buffer handle))
+	    (prog1
 	    (mm-decode-content-transfer-encoding
 	     (mm-handle-encoding handle)
 	     (mm-handle-media-type handle))
 	    (let ((temp (current-buffer)))
 	      (set-buffer cur)
-	      (insert-buffer-substring temp)))
+		(insert-buffer-substring temp))))
 	(mm-with-unibyte-buffer
 	  (insert-buffer-substring (mm-handle-buffer handle))
+	  (prog1
 	  (mm-decode-content-transfer-encoding
 	   (mm-handle-encoding handle)
 	   (mm-handle-media-type handle))
 	  (let ((temp (current-buffer)))
 	    (set-buffer cur)
-	    (insert-buffer-substring temp)))))))
+	      (insert-buffer-substring temp))))))))
 
 (defun mm-file-name-delete-whitespace (file-name)
   "Remove all whitespace characters from FILE-NAME."
@@ -959,7 +961,8 @@
 
 (defun mm-save-part-to-file (handle file)
   (mm-with-unibyte-buffer
-    (mm-insert-part handle)
+    (or (mm-insert-part handle)
+	(error "Error with message"))
     (let ((coding-system-for-write 'binary)
 	  ;; Don't re-compress .gz & al.  Arguably we should make
 	  ;; `file-name-handler-alist' nil, but that would chop