Gnus development mailing list
 help / color / mirror / Atom feed
From: Simon Josefsson <jas@extundo.com>
Subject: Re: Trailing whitespace and PGP/MIME
Date: Tue, 30 Dec 2003 12:05:51 +0100	[thread overview]
Message-ID: <iluekumr2eo.fsf@latte.josefsson.org> (raw)
In-Reply-To: <m3fzf3hwz4.fsf@defun.localdomain> (Jesper Harder's message of "Tue, 30 Dec 2003 03:15:43 +0100")

Jesper Harder <harder@ifa.au.dk> writes:

> Currently Gnus violates this requirement in RFC 3156 (MIME Security
> with OpenPGP):
>
>    implementations MUST make sure that no trailing whitespace is
>    present after the MIME encoding has been applied.
>
> Fixing it the obvious way would, however, break the intention of this
> change:
>
> 2003-10-27  Simon Josefsson  <jas@extundo.com>
>
> 	* mm-bodies.el (mm-body-encoding): Don't use QP when message body
> 	only consists of short lines and ASCII, when
> 	mm-use-ultra-safe-encoding.  Refer to 'About foo' thread in
> 	gnus-bug, e.g. <ilullrg4k7p.fsf@extundo.com>, for more discussion.
> 	This make it possible to pipe the raw RFC 822 message into 'gpg'
> 	and have the signature work.  Potential problem: what if message
> 	contain data that would be dash-escaped by OpenPGP
> 	implementations? Then PGP 2.x might not be able to parse the raw
> 	RFC 822 message correctly.  If that problem is worth fixing, it
> 	should be fixed by detecting the situation, instead of applying QP
> 	to everything.  Based on discussion with "John A. Martin"
> 	<jam@jamux.com>.

I think detecting if there are trailing SPC, and using QP in that case
is reasonable.  Does this work?

--- mm-bodies.el.~6.29.~	2003-12-26 06:32:11.000000000 +0100
+++ mm-bodies.el	2003-12-30 12:05:33.000000000 +0100
@@ -132,7 +132,8 @@
     (cond
      ((and (not longp)
 	   (not (and mm-use-ultra-safe-encoding
-		     (save-excursion (re-search-forward "^From " nil t))))
+		     (save-excursion (or (re-search-forward "^From " nil t)
+					 (re-search-forward " $" nil t)))))
 	   (eq bits '7bit))
       bits)
      ((and (not mm-use-ultra-safe-encoding)




  parent reply	other threads:[~2003-12-30 11:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-30  2:15 Jesper Harder
2003-12-30  9:04 ` Ivan Boldyrev
2003-12-30 11:31   ` Simon Josefsson
2003-12-30 13:12     ` Ivan Boldyrev
2003-12-30 11:05 ` Simon Josefsson [this message]
2003-12-30 13:02   ` Jesper Harder
2003-12-30 20:56     ` Simon Josefsson
2003-12-30 23:29       ` Jesper Harder
2003-12-30 23:52         ` Simon Josefsson
2003-12-31  0:01           ` Russ Allbery
2003-12-30 23:46       ` Russ Allbery
2003-12-31  0:05         ` Simon Josefsson
2003-12-31  2:26           ` Russ Allbery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iluekumr2eo.fsf@latte.josefsson.org \
    --to=jas@extundo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).