From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/25345 Path: main.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.gnus.general Subject: Re: browse-url button following mangles commas in URLs Date: 25 Sep 1999 13:57:49 +0200 Sender: owner-ding@hpc.uh.edu Message-ID: References: NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1035162747 13502 80.91.224.250 (21 Oct 2002 01:12:27 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 01:12:27 +0000 (UTC) Cc: ding@gnus.org Return-Path: Original-Received: from bart.math.uh.edu (bart.math.uh.edu [129.7.128.48]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id IAA11894 for ; Sat, 25 Sep 1999 08:00:51 -0400 (EDT) Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5]) by bart.math.uh.edu (8.9.1/8.9.1) with ESMTP id HAB20438; Sat, 25 Sep 1999 07:00:15 -0500 (CDT) Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Sat, 25 Sep 1999 07:00:15 -0500 (CDT) Original-Received: from sclp3.sclp.com (root@sclp3.sclp.com [204.252.123.139]) by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id HAA21079 for ; Sat, 25 Sep 1999 07:00:04 -0500 (CDT) Original-Received: from badis.pdc.kth.se (jas@badis.pdc.kth.se [130.237.221.45]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id HAA11871 for ; Sat, 25 Sep 1999 07:58:02 -0400 (EDT) Original-Received: (from jas@localhost) by badis.pdc.kth.se (8.9.3/8.9.3) id NAA21127; Sat, 25 Sep 1999 13:57:50 +0200 Original-To: Neil Crellin In-Reply-To: Neil Crellin's message of "24 Sep 1999 10:02:16 -0700" Original-Lines: 38 User-Agent: Gnus/5.070096 (Pterodactyl Gnus v0.96) Emacs/20.4 Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:25345 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:25345 Neil Crellin writes: > When presented with a buttonized url in gnus such as the following: > > > > if I click on the button, the URL is mangled with every comma replaced > by 2c like so: > > > > Now %2c in place of "," would be fine, but just 2c is no good. > > Can anyone see where this is occuring, I found this too convoluted to > debug properly, sorry. The bug is fixed in Emacs 20.4. I believe the patch below would work (stolen from gnu.emacs.bug). It's not a gnus problem. *** browse-url.el Mon Sep 13 10:54:56 1999 --- browse-url.el~ Fri Jun 19 18:02:11 1998 *************** *** 700,706 **** ;; include at least commas; presumably also close parens. (while (string-match "[,)]" url) (setq url (replace-match ! (format "%%%x" (string-to-char (match-string 0 url))) t t url))) (let* ((process-environment (browse-url-process-environment)) (process (apply 'start-process (concat "netscape " url) nil --- 700,706 ---- ;; include at least commas; presumably also close parens. (while (string-match "[,)]" url) (setq url (replace-match ! (format "%x" (string-to-char (match-string 0 url))) t t url))) (let* ((process-environment (browse-url-process-environment)) (process (apply 'start-process (concat "netscape " url) nil