From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/54317 Path: main.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.gnus.general Subject: Re: iso-8859-2 characters are broken in forwarded messages. Date: Sat, 18 Oct 2003 03:00:10 +0200 Sender: ding-owner@lists.math.uh.edu Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1066438835 5076 80.91.224.253 (18 Oct 2003 01:00:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 18 Oct 2003 01:00:35 +0000 (UTC) Original-X-From: ding-owner+M2858@lists.math.uh.edu Sat Oct 18 03:00:33 2003 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AAfSL-0008RG-00 for ; Sat, 18 Oct 2003 03:00:33 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1AAfS7-0003hU-00; Fri, 17 Oct 2003 20:00:19 -0500 Original-Received: from justine.libertine.org ([66.139.78.221]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1AAfS3-0003hP-00 for ding@lists.math.uh.edu; Fri, 17 Oct 2003 20:00:15 -0500 Original-Received: from yxa.extundo.com (178.230.13.217.in-addr.dgcsystems.net [217.13.230.178]) by justine.libertine.org (Postfix) with ESMTP id 1028E3A00C3 for ; Fri, 17 Oct 2003 20:00:14 -0500 (CDT) Original-Received: from latte (yxa.extundo.com [217.13.230.178]) (authenticated bits=0) by yxa.extundo.com (8.12.10/8.12.10) with ESMTP id h9I10C1e017095 for ; Sat, 18 Oct 2003 03:00:13 +0200 Original-To: ding@gnus.org Mail-Copies-To: nobody X-Payment: hashcash 1.2 0:031018:ding@gnus.org:57b1a60dc573e8c3 X-Hashcash: 0:031018:ding@gnus.org:57b1a60dc573e8c3 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Sat, 18 Oct 2003 02:43:29 +0200") User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (gnu/linux) Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:54317 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:54317 Lars Magne Ingebrigtsen writes: > Simon Josefsson writes: > >> Yes, that sounds like a good idea. Never MIME->MML convert >> multipart/{signed,encrypted} MIME parts. > > What would be the simplest fix for `message-forward-make-body' to > make it detect whether there are signed/encrypted parts in the > message? Try the MIME->MML conversion and re-search for '<#part type=multipart/(signed|encrypted)' and fall back to raw MIME found? > (`message-forward-as-mime' should have a third value, > `all-except-signed' or something to trigger the "guessing" code.) I think it should be `message-forward-show-mml' instead of m-f-a-m. The function look somewhat convoluted, I can't think of a minimal patch that solves the problem. I think the best would be to split up the code into message-forward-make-body-digest, message-forward-make-body-mime, message-forward-make-body-mml and message-forward-make-body-plain and make the top-level message-forward-make-body contain some logic and then call one of the real functions. And can't we remove the following as well? I think it would be nice to get rid of all of these. IMHO, they should only be used in the (very few) places where it is actually required. (goto-char (point-min)) (when (looking-at "From ") (replace-match "X-From-Line: ")) (goto-char (point-max)))))