Gnus development mailing list
 help / color / mirror / Atom feed
From: Simon Josefsson <jas@extundo.com>
Cc: bugs@gnus.org, ding@gnus.org
Subject: Re: article expiry and "B del"
Date: Tue, 09 Jul 2002 15:24:37 +0200	[thread overview]
Message-ID: <ilufzytavai.fsf@latte.josefsson.org> (raw)
In-Reply-To: <87fzyuv04z.fsf@localhost.i-did-not-set--mail-host-address--so-tickle-me> (Adrian Kubala's message of "Mon, 08 Jul 2002 15:07:24 +0200")

(CC'ing this to ding since someone had reported the bug discussed in
the last thread..)

Adrian Kubala <adrian@sixfingeredman.net> writes:

> The behaviour of "B del" is poorly documented and confusing. 
> Specifically, the "expiry-target" settings are NOT respected, but the
> nnmail-expiry-target IS. The reason is that the nnmail-expiry-target
> is overridden to use the group's expiry-target only in the function
> `gnus-group-expire-articles-1', and not in
> `gnus-request-expire-articles' where one would think it should be.

This was fixed recently by Nevin Kapur, I think.

> If it were up to me, I'd want one command to force expiration of
> selected articles (respecting expiry-target), and another to actually
> DELETE them, so that I can delete rather than expiring.

Doesn't `gnus-summary-expire-articles-now' expire such articles
correctly?  Maybe B DEL should be reverted to not respect
expiry-target at all then.

Yes, looking at g-s-e-a-n, it seems the last patch was not sufficient;
variables like expiry-wait should also be searched from group
parameters.

I suggest this, making B DEL really delete articles.  Opinions?

--- gnus-sum.el.~6.216.~	Tue Jul  9 15:15:09 2002
+++ gnus-sum.el	Tue Jul  9 15:23:04 2002
@@ -8826,9 +8826,7 @@
     (error "Couldn't open server"))
   ;; Compute the list of articles to delete.
   (let ((articles (sort (copy-sequence (gnus-summary-work-articles n)) '<))
-	(nnmail-expiry-target
-	 (or (gnus-group-find-parameter gnus-newsgroup-name 'expiry-target)
-	     nnmail-expiry-target))
+	(nnmail-expiry-target)
 	not-deleted)
     (if (and gnus-novice-user
 	     (not (gnus-yes-or-no-p




       reply	other threads:[~2002-07-09 13:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87fzyuv04z.fsf@localhost.i-did-not-set--mail-host-address--so-tickle-me>
2002-07-09 13:24 ` Simon Josefsson [this message]
2002-07-09 13:56   ` Kai Großjohann
2002-07-09 14:06   ` Nevin Kapur
     [not found] ` <ageop0$fk4$1@quimby.gnus.org>
2002-07-09 13:49   ` Frank Schmitt
2002-07-11 15:57     ` Amos Gouaux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ilufzytavai.fsf@latte.josefsson.org \
    --to=jas@extundo.com \
    --cc=bugs@gnus.org \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).