From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/45597 Path: main.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.gnus.general Subject: Re: article expiry and "B del" Date: Tue, 09 Jul 2002 15:24:37 +0200 Sender: owner-ding@hpc.uh.edu Message-ID: References: <87fzyuv04z.fsf@localhost.i-did-not-set--mail-host-address--so-tickle-me> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1026221139 12788 127.0.0.1 (9 Jul 2002 13:25:39 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 9 Jul 2002 13:25:39 +0000 (UTC) Cc: bugs@gnus.org, ding@gnus.org Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17Ruzr-0003K9-00 for ; Tue, 09 Jul 2002 15:25:39 +0200 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 17RuzB-0004aA-00; Tue, 09 Jul 2002 08:24:57 -0500 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Tue, 09 Jul 2002 08:25:20 -0500 (CDT) Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id IAA24421 for ; Tue, 9 Jul 2002 08:25:08 -0500 (CDT) Original-Received: (qmail 9967 invoked by alias); 9 Jul 2002 13:24:40 -0000 Original-Received: (qmail 9957 invoked from network); 9 Jul 2002 13:24:39 -0000 Original-Received: from 178.230.13.217.in-addr.dgcsystems.net (HELO yxa.extundo.com) (217.13.230.178) by gnus.org with SMTP; 9 Jul 2002 13:24:39 -0000 Original-Received: from latte.josefsson.org (yxa.extundo.com [217.13.230.178]) (authenticated bits=0) by yxa.extundo.com (8.12.5/8.12.5) with ESMTP id g69DObwF020643; Tue, 9 Jul 2002 15:24:38 +0200 Original-To: Adrian Kubala X-Hashcash: 020709:adrian@sixfingeredman.net:cb5bcb9face66705 X-Hashcash: 020709:bugs@gnus.org:262d16360be08030 X-Hashcash: 020709:ding@gnus.org:c3a36c00816f60ba In-Reply-To: <87fzyuv04z.fsf@localhost.i-did-not-set--mail-host-address--so-tickle-me> (Adrian Kubala's message of "Mon, 08 Jul 2002 15:07:24 +0200") Original-Lines: 41 User-Agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.2 (i386-debian-linux-gnu) X-Spam-Status: No, hits=-5.6 required=5.0 tests=IN_REP_TO,GAPPY_TEXT version=2.20 Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:45597 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:45597 (CC'ing this to ding since someone had reported the bug discussed in the last thread..) Adrian Kubala writes: > The behaviour of "B del" is poorly documented and confusing. > Specifically, the "expiry-target" settings are NOT respected, but the > nnmail-expiry-target IS. The reason is that the nnmail-expiry-target > is overridden to use the group's expiry-target only in the function > `gnus-group-expire-articles-1', and not in > `gnus-request-expire-articles' where one would think it should be. This was fixed recently by Nevin Kapur, I think. > If it were up to me, I'd want one command to force expiration of > selected articles (respecting expiry-target), and another to actually > DELETE them, so that I can delete rather than expiring. Doesn't `gnus-summary-expire-articles-now' expire such articles correctly? Maybe B DEL should be reverted to not respect expiry-target at all then. Yes, looking at g-s-e-a-n, it seems the last patch was not sufficient; variables like expiry-wait should also be searched from group parameters. I suggest this, making B DEL really delete articles. Opinions? --- gnus-sum.el.~6.216.~ Tue Jul 9 15:15:09 2002 +++ gnus-sum.el Tue Jul 9 15:23:04 2002 @@ -8826,9 +8826,7 @@ (error "Couldn't open server")) ;; Compute the list of articles to delete. (let ((articles (sort (copy-sequence (gnus-summary-work-articles n)) '<)) - (nnmail-expiry-target - (or (gnus-group-find-parameter gnus-newsgroup-name 'expiry-target) - nnmail-expiry-target)) + (nnmail-expiry-target) not-deleted) (if (and gnus-novice-user (not (gnus-yes-or-no-p