From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/29500 Path: main.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.gnus.general Subject: Re: major problem with recent cvs Date: 14 Mar 2000 12:42:35 +0100 Sender: owner-ding@hpc.uh.edu Message-ID: References: NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: main.gmane.org 1035166159 3082 80.91.224.250 (21 Oct 2002 02:09:19 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 02:09:19 +0000 (UTC) Cc: lconrad@world.std.com, ding@gnus.org, bugs@gnus.org Return-Path: Original-Received: from lisa.math.uh.edu (lisa.math.uh.edu [129.7.128.49]) by mailhost.sclp.com (Postfix) with ESMTP id 6B114D051E for ; Tue, 14 Mar 2000 06:43:14 -0500 (EST) Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5]) by lisa.math.uh.edu (8.9.1/8.9.1) with ESMTP id FAB17756; Tue, 14 Mar 2000 05:43:08 -0600 (CST) Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Tue, 14 Mar 2000 05:42:45 -0600 (CST) Original-Received: from mailhost.sclp.com (postfix@sclp3.sclp.com [204.252.123.139]) by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id FAA22420 for ; Tue, 14 Mar 2000 05:42:35 -0600 (CST) Original-Received: from badis.pdc.kth.se (badis.pdc.kth.se [130.237.221.45]) by mailhost.sclp.com (Postfix) with ESMTP id D9A00D051E; Tue, 14 Mar 2000 06:42:44 -0500 (EST) Original-Received: (from jas@localhost) by badis.pdc.kth.se (8.10.0/8.10.0) id e2EBgag31692; Tue, 14 Mar 2000 12:42:36 +0100 Original-To: Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai=?iso-8859-1?q?_Gro=DFjohann?=) In-Reply-To: Kai.Grossjohann@CS.Uni-Dortmund.DE's message of "14 Mar 2000 11:48:37 +0100" Original-Lines: 59 User-Agent: Gnus/5.0804 (Gnus v5.8.4) Emacs/20.6 Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:29500 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:29500 Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Gro=DFjohann) writes: > > + (expand-file-name (concat group "/") dir) >=20 > Do you think it would be good to use the following instead? >=20 > (file-name-as-directory (expand-file-name group dir)) >=20 > Just a thought. Good idea, here's a new patch. Index: lisp/nnmail.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /usr/local/cvsroot/gnus/lisp/nnmail.el,v retrieving revision 5.48 diff -w -u -r5.48 nnmail.el --- lisp/nnmail.el 2000/03/13 19:43:14 5.48 +++ lisp/nnmail.el 2000/03/14 11:43:56 @@ -470,13 +470,14 @@ ;; If this directory exists, we use it directly. (if (or nnmail-use-long-file-names (file-directory-p (concat dir group))) - (expand-file-name group dir) + (file-name-as-directory (expand-file-name group dir)) ;; If not, we translate dots into slashes. + (file-name-as-directory (expand-file-name (mm-encode-coding-string (nnheader-replace-chars-in-string group ?. ?/) nnmail-pathname-coding-system) - dir))) + dir)))) (or file ""))) =20 (defun nnmail-get-active () Index: lisp/nnheader.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /usr/local/cvsroot/gnus/lisp/nnheader.el,v retrieving revision 5.35 diff -w -u -r5.35 nnheader.el --- lisp/nnheader.el 2000/03/13 13:50:38 5.35 +++ lisp/nnheader.el 2000/03/14 11:43:56 @@ -730,12 +730,13 @@ (let ((dir (file-name-as-directory (expand-file-name dir)))) ;; If this directory exists, we use it directly. (if (file-directory-p (concat dir group)) - (expand-file-name group dir) + (file-name-as-directory (expand-file-name group dir)) ;; If not, we translate dots into slashes. + (file-name-as-directory (expand-file-name (mm-encode-coding-string (nnheader-replace-chars-in-string group ?. ?/) nnheader-pathname-coding-system) - dir))) + dir)))) (cond ((null file) "") ((numberp file) (int-to-string file)) (t file))))