Re: message-remove-duplicates and gnus-remove-duplicates

[Simon Josefsson <jas@extundo.com>]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> On Mon, Oct 03 2005, Simon Josefsson wrote:
>
>> Reiner Steib <reinersteib+gmane@imap.cc> writes:
> [...]
>>> --8<---------------cut here---------------start------------->8---
>>> ;; In case external packages use `gnus-remove-duplicates', we provide an
>>> ;; alias.  In new code, `mm-delete-duplicates' or `delete-dups' should be
>>> ;; used.
>>> (defalias 'gnus-remove-duplicates 'mm-delete-duplicates)
>>> --8<---------------cut here---------------end--------------->8---
>>
>> Yes, I think that is good.  Perhaps instead use:
>>
>> (define-obsolete-function-alias 'gnus-remove-duplicates 'mm-delete-duplicates)
>
> For compatibility with Emacs 20.7 (v5-10), Emacs 21 and maybe older
> XEmacs versions we probably need:
>
> (if (fboundp 'define-obsolete-function-alias)
>     (define-obsolete-function-alias
>       'gnus-remove-duplicates 'mm-delete-duplicates
>       "22.1");; Gnus 5.10.7 / Gnus 5.11 / No Gnus
>   (defalias 'gnus-remove-duplicates 'mm-delete-duplicates)
>   (make-obsolete 'gnus-remove-duplicates 'mm-delete-duplicates "22.1"))

Do we need to make this change in 5-10?  It doesn't look like a bug
fix to me.  No Gnus assume at least Emacs 21.1 or XEmacs 21.4, which
has d-o-f-a, so no need to fall back to old code.