Gnus development mailing list
 help / color / mirror / Atom feed
From: Simon Josefsson <jas@extundo.com>
Subject: Re: possible bug: article marks are wrong when moving article
Date: Sat, 24 May 2003 16:07:09 +0200	[thread overview]
Message-ID: <iluhe7k4ewi.fsf@latte-wlan.josefsson.org> (raw)
In-Reply-To: <m38ysw7gmr.fsf@heechee.beld.net> (Ted Zlatanov's message of "Sat, 24 May 2003 07:01:32 -0400")

Ted Zlatanov <tzz@lifelogs.com> writes:

> On Fri, 23 May 2003, jas@extundo.com wrote:
>> Ted Zlatanov <tzz@lifelogs.com> writes:
>> 
>>> Simple to replicate, only tested under nnimap but might be
>>> backend-independendent:
>>>
>>> pick a previously ticked article
>>>
>>> unmark it (M-u)
>>>
>>> move it to another group
>>>
>>> The article just moved is still ticked.
>>>
>>> Can anyone verify that this is a bug and not something caused by my
>>> configuration?
>> 
>> I didn't reproduce it, but it is most likely a bug.  The reason is
>> that Gnus only propagate marks in the summary buffer to the server
>> when you quit the summary buffer.  If you unmark something and then
>> move it, the move command will use the old flags.  The solution
>> would be to make the move command change the flags, alas I don't
>> have a specific patch in mind.
>
> So the temporary solution is to quit the summary, go back and then
> move?

Yup.  Or move it and mark it in the new folder.

> Is the "update marks on server" command a stand-alone function that
> the article move/copy operation can trigger?  If you could point me to
> where it happens, maybe I can do the rest.

gnus-summary-update-info is run on 'q' and propagates the flags, but
that shouldn't be called at move time since it updates all flags.  I
think the proper solution would be to move the article and then call
gnus-request-set-mark from gnus-summary-move-article, but this seems
to already happen.  Perhaps there is a bug?  Yes, it seems to only do
set-mark with the 'add operation, which only add the correct marks.
The problem here seem to be that some marks are not removed too.  So
it should do another call with 'del, or the logic should be replaced
with some logic that finds out all flags and then do a 'set operation.




  reply	other threads:[~2003-05-24 14:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-23 17:59 Ted Zlatanov
2003-05-23 21:19 ` Simon Josefsson
2003-05-24 11:01   ` Ted Zlatanov
2003-05-24 14:07     ` Simon Josefsson [this message]
2003-05-25 11:02       ` Michael R. Wolf
2003-05-25 14:38         ` Simon Josefsson
2003-05-25 23:52           ` Michael R. Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iluhe7k4ewi.fsf@latte-wlan.josefsson.org \
    --to=jas@extundo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).