From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/49310 Path: main.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.gnus.general Subject: Re: gnus-convert-image-to-face-command Date: Thu, 16 Jan 2003 18:53:01 +0100 Sender: owner-ding@hpc.uh.edu Message-ID: References: <87vg0p9nep.fsf@orebokech.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1042739626 12366 80.91.224.249 (16 Jan 2003 17:53:46 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 16 Jan 2003 17:53:46 +0000 (UTC) Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18ZED0-0003D2-00 for ; Thu, 16 Jan 2003 18:53:42 +0100 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 18ZECu-0000d6-00; Thu, 16 Jan 2003 11:53:36 -0600 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Thu, 16 Jan 2003 11:54:33 -0600 (CST) Original-Received: from sclp3.sclp.com (sclp3.sclp.com [66.230.238.2]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id LAA13862 for ; Thu, 16 Jan 2003 11:54:19 -0600 (CST) Original-Received: (qmail 99960 invoked by alias); 16 Jan 2003 17:53:04 -0000 Original-Received: (qmail 99955 invoked from network); 16 Jan 2003 17:53:03 -0000 Original-Received: from 178.230.13.217.in-addr.dgcsystems.net (HELO yxa.extundo.com) (217.13.230.178) by 66.230.238.6 with SMTP; 16 Jan 2003 17:53:03 -0000 Original-Received: from latte.josefsson.org (yxa.extundo.com [217.13.230.178]) (authenticated bits=0) by yxa.extundo.com (8.12.6/8.12.6) with ESMTP id h0GHr1Rr001725 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO) for ; Thu, 16 Jan 2003 18:53:02 +0100 Original-To: ding@gnus.org Mail-Copies-To: nobody X-Payment: hashcash 1.1 0:030116:ding@gnus.org:805008a46806023c X-Hashcash: 0:030116:ding@gnus.org:805008a46806023c In-Reply-To: <87vg0p9nep.fsf@orebokech.com> (Romain FRANCOISE's message of "Thu, 16 Jan 2003 15:31:26 +0100") User-Agent: Gnus/5.090013 (Oort Gnus v0.13) XEmacs/21.4 (Portable Code, i686-pc-linux) X-Face: 1Yn@M+tp9bHO[8c_KMq4EAehxF;z,'j|yrivOiG+mxk$hnZac61A{@h6 writes: > 2003-01-16 Simon Josefsson > > * gnus-fun.el (gnus-convert-image-to-x-face-command) > (gnus-convert-image-to-face-command, gnus-x-face-from-file) > (gnus-face-from-file): Doc fix; don't mention image format. > > Er, could you please revert this? The image format *is* important in > the docstring, in the first case (X-Face) we expect a GIF whereas in > the other (Face), we expect a JPEG. The only thing that needed fixing > is the gnus-convert-image-to-face-command docstring, which is *still* > incorrect, it should be: > > "Command for converting a JPEG image to a Face." > > not > > "Command for converting an image to an X-Face." Isn't the only thing that depend on what format the file must be in the command the variable itself specifies? (defcustom gnus-convert-image-to-x-face-command "giftopnm %s | ppmnorm | pnmscale -width 48 -height 48 | ppmtopgm | pgmtopbm | pbmtoxbm | compface" "Command for converting an image to an X-Face." The user may change the command to use jpegtopnm or something entirely different, and then the variable documentation would be confusing. If the user isn't supposed to be able to alter the command, perhaps it should be made into a constant. What do you think of the following solution as a compromise? "Command for converting an image to an X-Face. The default is to convert from GIF images by using giftopnm and some other programs."