Re: message-remove-duplicates and gnus-remove-duplicates

[Simon Josefsson <jas@extundo.com>]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> On Mon, Oct 03 2005, Simon Josefsson wrote:
>
>> Reiner Steib <reinersteib+gmane@imap.cc> writes:
> [...]
>>> For compatibility with Emacs 20.7 (v5-10), Emacs 21 and maybe older
>>> XEmacs versions we probably need:
>>>
>>> (if (fboundp 'define-obsolete-function-alias)
>>>     (define-obsolete-function-alias
>>>       'gnus-remove-duplicates 'mm-delete-duplicates
>>>       "22.1");; Gnus 5.10.7 / Gnus 5.11 / No Gnus
>>>   (defalias 'gnus-remove-duplicates 'mm-delete-duplicates)
>>>   (make-obsolete 'gnus-remove-duplicates 'mm-delete-duplicates "22.1"))
>>
>> Do we need to make this change in 5-10?  It doesn't look like a bug
>> fix to me.
>
> IMHO it's not a good idea to have three functions for the same purpose
> in v5-10.  Probably it was an oversight that we had two functions in
> the first place (because of "delete" vs. "remove"?).  But now we have
> three.
>
>> No Gnus assume at least Emacs 21.1 or XEmacs 21.4, which has
>> d-o-f-a, so no need to fall back to old code.
>
> Emacs 21 doesn't have it, so we need the fall back code even in No
> Gnus.  Given that, I think it's best to have the same code in trunk
> and v5-10.

Ok, you convinced me.