From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/61088 Path: news.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.gnus.general Subject: Re: message-remove-duplicates and gnus-remove-duplicates Date: Tue, 04 Oct 2005 12:01:25 +0200 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1128420185 10962 80.91.229.2 (4 Oct 2005 10:03:05 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 4 Oct 2005 10:03:05 +0000 (UTC) Original-X-From: ding-owner+m9620@lists.math.uh.edu Tue Oct 04 12:03:03 2005 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EMjd3-0004tG-10 for ding-account@gmane.org; Tue, 04 Oct 2005 12:02:33 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1EMjcz-0003uO-00; Tue, 04 Oct 2005 05:02:29 -0500 Original-Received: from nas02.math.uh.edu ([129.7.128.40]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1EMjcL-0003uJ-00 for ding@lists.math.uh.edu; Tue, 04 Oct 2005 05:01:49 -0500 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas02.math.uh.edu with esmtp (Exim 4.52) id 1EMjcG-0002Aw-Ok for ding@lists.math.uh.edu; Tue, 04 Oct 2005 05:01:47 -0500 Original-Received: from 178.230.13.217.in-addr.dgcsystems.net ([217.13.230.178] helo=yxa.extundo.com) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1EMjcA-00063H-00 for ; Tue, 04 Oct 2005 12:01:39 +0200 Original-Received: from latte.josefsson.org (c494102a.s-bi.bostream.se [217.215.27.65]) (authenticated bits=0) by yxa.extundo.com (8.13.4/8.13.4/Debian-3) with ESMTP id j94A1Tt0006780 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Oct 2005 12:01:33 +0200 Original-To: ding@gnus.org OpenPGP: id=B565716F; url=http://josefsson.org/key.txt X-Hashcash: 1:21:051004:ding@gnus.org::heHQkdzwZEmJ+5I0:3p6P In-Reply-To: (Reiner Steib's message of "Mon, 03 Oct 2005 19:55:39 +0200") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Spam-Status: No, score=0.1 required=5.0 tests=FORGED_RCVD_HELO autolearn=failed version=3.0.3 X-Spam-Checker-Version: SpamAssassin 3.0.3 (2005-04-27) on yxa-iv X-Virus-Scanned: ClamAV version 0.84, clamav-milter version 0.84e on yxa.extundo.com X-Virus-Status: Clean X-Spam-Score: -2.5 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:61088 Archived-At: Reiner Steib writes: > On Mon, Oct 03 2005, Simon Josefsson wrote: > >> Reiner Steib writes: > [...] >>> For compatibility with Emacs 20.7 (v5-10), Emacs 21 and maybe older >>> XEmacs versions we probably need: >>> >>> (if (fboundp 'define-obsolete-function-alias) >>> (define-obsolete-function-alias >>> 'gnus-remove-duplicates 'mm-delete-duplicates >>> "22.1");; Gnus 5.10.7 / Gnus 5.11 / No Gnus >>> (defalias 'gnus-remove-duplicates 'mm-delete-duplicates) >>> (make-obsolete 'gnus-remove-duplicates 'mm-delete-duplicates "22.1")) >> >> Do we need to make this change in 5-10? It doesn't look like a bug >> fix to me. > > IMHO it's not a good idea to have three functions for the same purpose > in v5-10. Probably it was an oversight that we had two functions in > the first place (because of "delete" vs. "remove"?). But now we have > three. > >> No Gnus assume at least Emacs 21.1 or XEmacs 21.4, which has >> d-o-f-a, so no need to fall back to old code. > > Emacs 21 doesn't have it, so we need the fall back code even in No > Gnus. Given that, I think it's best to have the same code in trunk > and v5-10. Ok, you convinced me.