Re: <#secure method=pgp mode=sign> is broken for koi8-r

[Simon Josefsson <jas@extundo.com>]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> deskpot@myrealbox.com (Vasily Korytov) writes:
>
>>  VK> Attached is the message, signed with method=pgp in just updated from CVS
>>  VK> Gnus, containing only one Cyrillic word: ``тест'' (transliteration for
>>  VK> ``test''). Note, that I didn't forward it from Gnus, but copied it
>>  VK> directly from my mailbox.
>>
>> Sorry, Gnus had tweaked it, while sending so I'll paste it again -- this
>> time, inline. Here it goes:
>
> I'm not all that familiar with the PGP code -- could someone more
> familiar take a peek at this problem?

Supporting MIME and non-MIME aware OpenPGP at the same time is tricky.
I installed the following, which is based on the assumption that users
don't want to clear-sign non-textual material.

The non-MIME aware OpenPGP support in Gnus should be revisited
somewhat IMHO, right it works for textual data (unless there are more
problems similar to this one), but it would be nice to support more.
I.e., attaching files and marking that part with "sign=pgp" should
encode it as a normal, non-clearsigned, OpenPGP message with the MIME
headers left unchanged (this would make it interoperate with various
Outlook plugins).

--- mm-encode.el.~6.12.~	Sun Dec  1 16:53:21 2002
+++ mm-encode.el	Sat Jan 25 20:32:54 2003
@@ -164,6 +164,9 @@
 	(pop rules)))))
 
 (defun mm-qp-or-base64 ()
+  (if (equal mm-use-ultra-safe-encoding '(sign . "pgp"))
+      ;; perhaps not always accurate?
+      'quoted-printable
   (save-excursion
     (let ((limit (min (point-max) (+ 2000 (point-min))))
 	  (n8bit 0))
@@ -178,7 +181,7 @@
 	      ;; non-ASCII char when splitting parts by charset.
 	      (= n8bit 1))
 	  'quoted-printable
-	'base64))))
+	  'base64)))))
 
 (provide 'mm-encode)