From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/45108 Path: main.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.gnus.general Subject: Re: Two gnus-posting-styles problems Date: Tue, 04 Jun 2002 18:07:45 +0200 Sender: owner-ding@hpc.uh.edu Message-ID: References: NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1023207083 13782 127.0.0.1 (4 Jun 2002 16:11:23 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 4 Jun 2002 16:11:23 +0000 (UTC) Cc: bugs@gnus.org (The Gnus Bugfixing Girls + Boys), ding@gnus.org Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17FGu3-0003aB-00 for ; Tue, 04 Jun 2002 18:11:23 +0200 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 17FGqt-0004Pc-00; Tue, 04 Jun 2002 11:08:07 -0500 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Tue, 04 Jun 2002 11:08:23 -0500 (CDT) Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id LAA03264 for ; Tue, 4 Jun 2002 11:08:09 -0500 (CDT) Original-Received: (qmail 12910 invoked by alias); 4 Jun 2002 16:07:48 -0000 Original-Received: (qmail 12900 invoked from network); 4 Jun 2002 16:07:47 -0000 Original-Received: from 178.230.13.217.in-addr.dgcsystems.net (HELO yxa.extundo.com) (217.13.230.178) by gnus.org with SMTP; 4 Jun 2002 16:07:47 -0000 Original-Received: from latte.josefsson.org (yxa.extundo.com [217.13.230.178]) (authenticated bits=0) by yxa.extundo.com (8.12.4/8.12.4) with ESMTP id g54G7iXq030837; Tue, 4 Jun 2002 18:07:44 +0200 Original-To: Hrvoje Niksic Mail-Copies-To: nobody In-Reply-To: (Hrvoje Niksic's message of "Tue, 04 Jun 2002 15:48:40 +0200") Original-Lines: 59 User-Agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.2.90 (i686-pc-linux-gnu) Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:45108 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:45108 Hrvoje Niksic writes: > But I won't test it for some time simply because I really need the > functionality to test the message buffer. If that can't be done with > the posting styles, then I'll just use a hook. Perhaps I'm simply not > the right target audience for posting styles. Perhaps this is reason enough to change it, like Kai said. Patches, anyone? :-) >>>> There's a dependency problem here, not all functions that use >>>> information from the message buffer and modify the contents of the >>>> message buffer can be called last. I think the ordering has changed >>>> several times, but it won't ever satisfy everyone. I think the >>>> approach should be that you shouldn't count on information being >>>> available in the message buffers unless... err, it is available. >>> >>> I'm not sure I understand this. Why can't it satisfy everyone? What >>> is the position opposite to mine? >> >> There are alot of hooks and functions that people use to populate >> message buffers: message-mode-hook, message-setup-hook, >> gnus-message-setup-hook, gnus-posting-styles, making user-mail-address >> context sensitive, defadvice etc. If we change the ordering the way >> you want, the posting style is applied last, which makes it possible >> to extract To/From etc from the newly composed message. But the same >> change will affect code added to, say, message-setup-hook, since it no >> longer can extract the fields added by the posting styles code. > > I suppose the posting styles could be applied before the > message-setup-hook is run. That won't work if people has code in message-setup-hook that assumes posting styles hasn't been applied yet, will it? That was the kind of trouble I feared would happen if we change the ordering. > But Kai has a good point: doing what I want might seriously clash with > `message-generate-headers-first'. Ouch, yes. > I do not see a way to resolve that, so I'll just keep my hook. At > least the `m'/`a' thing, which was a genuine bug, should now be > fixed, so something good came out of my report. > > Thanks for the fix. I'll commit it, thanks. >> That said, perhaps changing it to apply posting styles last is good, >> but it seems difficult to tell what harm to people's customizations >> it will generate. Leaving it as is doesn't hurt anything, > > Well. There *could* be a variable that controls when > `gnus-posting-styles' are applied. It could default to applying it in > the empty message buffer, which would make sure that existing > customizations keep working. Yup.