text/dns

text/dns

[Simon Josefsson]

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

FYI, I added some support for text/dns.  If you're using a recent No
Gnus, the file below should look unboring.  Holler if something
doesn't work.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: foo.soa --]
[-- Type: text/dns, Size: 755 bytes --]

$ORIGIN skenbe.net.
$FOO
$INCLUDE
$BAR
@                       1D IN SOA       44c. jas.pdc.ff42kth.se. (
			2004091109	; serial
                                        3H              ; refresh ;
                                        1H              ; retry
                                        1W              ; expiry
                                        1D )            ; minimum

                        IN NS   yxa.extundo.com.
                        IN NS   vic20.blipp.com.
                        IN NS   syl.extundo.com.

                        IN MX   5 yxa.extundo.com.
                        IN MX   10 syl.extundo.com.

                        IN A            217.13.230.178
www                     IN A            217.13.230.178

Re: text/dns

[Andrew A. Raines]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

Simon Josefsson <jas@extundo.com> writes:

> FYI, I added some support for text/dns.  If you're using a recent
> No Gnus, the file below should look unboring.  Holler if something
> doesn't work.

I get the attached error when trying to view your message.  I just
cvs uped about 5 minutes ago, ran make, and restarted Emacs for
safety.

-- 
    aaraines@pobox.com (Andrew A. Raines)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: text/dns problems --]
[-- Type: text/plain; charset=utf-8, Size: 2732 bytes --]

Debugger entered--Lisp error: (void-function dns-mode)
  dns-mode()
  mm-display-inline-fontify((#<buffer  *mm*<3>> ("text/dns") nil nil ("inline" (filename . "foo.soa")) nil nil nil) dns-mode)
  mm-display-dns-inline((#<buffer  *mm*<3>> ("text/dns") nil nil ("inline" (filename . "foo.soa")) nil nil nil))
  mm-display-inline((#<buffer  *mm*<3>> ("text/dns") nil nil ("inline" (filename . "foo.soa")) nil nil nil))
  mm-display-part((#<buffer  *mm*<3>> ("text/dns") nil nil ("inline" (filename . "foo.soa")) nil nil nil) t)
  byte-code("\bƒ\x17\0Æ\b‰A\x10@	\"ƒ\0\0ǁÀÈ\"ˆ‚\0\0É\n!?Â…1\0Ê\n8?†1\0Ê\n8@˚†1\0Ì\n!‰\x13ƒS\0Í\n!ƒS\0Î\n!ƒH\0Ï\n!„N\0Ð	!ƒS\0Ñ\x14‚d\0\n\x1aҁÓ\n!Ô\"@)՚ƒd\0Ñ\x15\x0e\"GTÈ\x1e#‰\x1e$\nB\x0e\"B\x16\"\fƒ\x7f\0Ö	!„•\0×\n\x0e$\f†Œ\0\vÂ…ÂŒ\0\rC#ÂˆÂØ ÂˆÂÑ\x16%`\x16#\fƒÂ\0\x0e%ƒ§\0Ùyˆ`\x16#\x0e&Šȁځۏˆ\x0e')\x1e(\x1e)Ü\nÑ\"ˆ*dbˆ‚â\0\rƒâ\0\vƒâ\0\x0e%ƒÕ\0Ùyˆ`\x16#ÂØ ÂˆÂÝ\nÞ\n!\"ˆdbˆŠŒ\x0e#`}ˆ߁È\x0e$à\x0e*@!ƒù\0ႁý\0\x0e*GS\n‰\x1a@;ƒ\n\x01\n@‚\x0e\x01á\n8@)$,‡" [ignored type handle not-attachment display text string-match throw nil mm-inline-override-p 4 "inline" mm-attachment-override-p mm-automatic-display-p mm-inlinable-p mm-inlined-p mm-automatic-external-display-p t split-string mm-handle-media-type "/" "text" gnus-unbuttonized-mime-type-p gnus-insert-mime-button gnus-article-insert-newline -1 (set-buffer gnus-summary-buffer) ((error)) mm-display-part mm-insert-inline mm-get-part gnus-treat-article bufferp 1 gnus-article-mime-handle-alist beg id move gnus-newsgroup-charset gnus-newsgroup-ignored-charsets mail-parse-ignored-charsets mail-parse-charset gnus-article-mime-handles] 7)
  gnus-mime-display-single((#<buffer  *mm*<3>> ("text/dns") nil nil ("inline" (filename . "foo.soa")) nil nil nil))
  gnus-mime-display-part((#<buffer  *mm*<3>> ("text/dns") nil nil ("inline" (filename . "foo.soa")) nil nil nil))
  mapcar(gnus-mime-display-part ((#<buffer  *mm*<2>> ("text/plain") nil (lambda nil ...) nil nil nil nil) (#<buffer  *mm*<3>> ("text/dns") nil nil ("inline" ...) nil nil nil)))
  gnus-mime-display-mixed(((#<buffer  *mm*<2>> ("text/plain") nil (lambda nil ...) nil nil nil nil) (#<buffer  *mm*<3>> ("text/dns") nil nil ("inline" ...) nil nil nil)))
  gnus-mime-display-part((#("multipart/mixed" 0 15 (start nil from "jas@extundo.com" buffer #<buffer  *mm*> boundary "=-=-=")) (#<buffer  *mm*<2>> ("text/plain") nil (lambda nil ...) nil nil nil nil) (#<buffer  *mm*<3>> ("text/dns") nil nil ("inline" ...) nil nil nil)))
  gnus-display-mime()
  gnus-article-prepare-display()
  gnus-article-prepare(53976 nil)
  gnus-summary-display-article(53976 nil)
  gnus-summary-select-article(nil nil pseudo)
  gnus-summary-scroll-up(1)
  call-interactively(gnus-summary-scroll-up)

Re: text/dns

[Romain Francoise]

"Andrew A. Raines" <aaraines@pobox.com> writes:

> I get the attached error when trying to view your message.  I just
> cvs uped about 5 minutes ago, ran make, and restarted Emacs for
> safety.

This could be because your Emacs/Gnus configuration does not have:

(require 'gnus-load)

which pulls the needed autoload for dns-mode.

-- 
Romain Francoise <romain@orebokech.com> | Wait, stop, wait just hold on
it's a miracle -- http://orebokech.com/ | a minute.

Re: text/dns

[Steve Youngs]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

* Simon Josefsson <jas@extundo.com> writes:

  > FYI, I added some support for text/dns.  If you're using a recent No
  > Gnus, the file below should look unboring.  Holler if something
  > doesn't work.

It doesn't generate any errors/warnings here.  But the only thing that
it does do is fontify "; sometexthere" in `font-lock-comment-face'.
Should there be more unboringness than that?

-- 
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
|                   Te audire no possum.                   |
|             Musa sapientum fixa est in aure.             |
|----------------------------------<steve@youngs.au.com>---|

[-- Attachment #2: Type: application/pgp-signature, Size: 256 bytes --]

Re: text/dns

[Simon Josefsson]

Steve Youngs <steve@youngs.au.com> writes:

> * Simon Josefsson <jas@extundo.com> writes:
>
>   > FYI, I added some support for text/dns.  If you're using a recent No
>   > Gnus, the file below should look unboring.  Holler if something
>   > doesn't work.
>
> It doesn't generate any errors/warnings here.  But the only thing that
> it does do is fontify "; sometexthere" in `font-lock-comment-face'.
> Should there be more unboringness than that?

Ah, I didn't test on XEmacs.  It should fontify comments ("; foo"),
the control entities ($ORIGIN, $INCLUDE), the non-standard control
entities ($FOO, $BAR), the DNS classes and types (IN, NS, SOA etc).

I'll try it on XEmacs now...

Re: text/dns

[Simon Josefsson]

Simon Josefsson <jas@extundo.com> writes:

>> It doesn't generate any errors/warnings here.  But the only thing that
>> it does do is fontify "; sometexthere" in `font-lock-comment-face'.
>> Should there be more unboringness than that?
>
> Ah, I didn't test on XEmacs.  It should fontify comments ("; foo"),
> the control entities ($ORIGIN, $INCLUDE), the non-standard control
> entities ($FOO, $BAR), the DNS classes and types (IN, NS, SOA etc).
>
> I'll try it on XEmacs now...

Hm.  Font-locking doesn't work alright.  But I can't find out why.  To
me, dns-mode.el seem to do the same as sieve-mode.el and dig.el for
font lock keywords, and both of them work.  Anyone?

Re: text/dns

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

>>>>> In <ilur7p7oex8.fsf@latte.josefsson.org> Simon Josefsson wrote:

> Hm.  Font-locking doesn't work alright.  But I can't find out why.  To
> me, dns-mode.el seem to do the same as sieve-mode.el and dig.el for
> font lock keywords, and both of them work.  Anyone?

In `dns-mode-font-lock-keywords', faces seem to have to be
existing face symbols.  So, defining all dns faces by defface or
modifying `dns-mode-font-lock-keywords' as follows would solve it.


[-- Attachment #2: Type: application/emacs-lisp, Size: 420 bytes --]

Re: text/dns

[Steve Youngs]

[-- Attachment #1: Type: text/plain, Size: 1412 bytes --]

* Katsumi Yamaoka <yamaoka@jpl.org> writes:

  >>>>>> In <ilur7p7oex8.fsf@latte.josefsson.org> Simon Josefsson wrote:
  >> Hm.  Font-locking doesn't work alright.  But I can't find out why.  To
  >> me, dns-mode.el seem to do the same as sieve-mode.el and dig.el for
  >> font lock keywords, and both of them work.  Anyone?

  > In `dns-mode-font-lock-keywords', faces seem to have to be
  > existing face symbols.  So, defining all dns faces by defface or
  > modifying `dns-mode-font-lock-keywords' as follows would solve it.
  > (defcustom dns-mode-font-lock-keywords
  >   `(("^$ORIGIN" 0 ,dns-mode-control-entity-face)
  >     ("^$INCLUDE" 0 ,dns-mode-control-entity-face)
  >     ("^$[a-z0-9A-Z]+" 0 ,dns-mode-bad-control-entity-face)
  >     (,(regexp-opt dns-mode-classes) 0 ,dns-mode-class-face)
  >     (,(regexp-opt dns-mode-types) 0 ,dns-mode-type-face))
  >   "Font lock keywords used to highlight text in DNS master file mode."
  >   :type 'sexp
  >   :group 'dns-mode)

Yes, that works for me.

I've just discovered another problem.  Once `dns-mode' is invoked, I
get a `DNS' menu in every new buffer (there's one in my message buffer
right now).


-- 
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
|                   Te audire no possum.                   |
|             Musa sapientum fixa est in aure.             |
|----------------------------------<steve@youngs.au.com>---|

[-- Attachment #2: Type: application/pgp-signature, Size: 256 bytes --]

Re: text/dns

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

>>>>> In <microsoft-free.87y8jeubr1.fsf@youngs.au.com> Steve Youngs wrote:

> I've just discovered another problem.  Once `dns-mode' is invoked, I
> get a `DNS' menu in every new buffer (there's one in my message buffer
> right now).

That occurs only in XEmacs 21.4.  I have nothing to indicate but
found using easy-menu-add instead of easy-menu-add-item helps.
This is what message-mode (which is derived from text-mode as
well) does.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 353 bytes --]

--- dns-mode.el~	2004-09-12 04:44:11 +0000
+++ dns-mode.el	2004-09-13 04:46:17 +0000
@@ -131,7 +131,7 @@
   (unless (featurep 'xemacs)
     (set (make-local-variable 'font-lock-defaults)
 	 '(dns-mode-font-lock-keywords nil nil ((?_ . "w")))))
-  (easy-menu-add-item nil nil dns-mode-menu))
+  (easy-menu-add dns-mode-menu dns-mode-map))
 
 ;; Tools.
 

[-- Attachment #3: Type: text/plain, Size: 222 bytes --]

However, I suspect there is something wrong in XEmacs 21.4 and I
don't think the above patch is a right solution.

In relation to this, the same problem occurs in XEmacs 21.4 also
by sieve-mode and sieve-manage-mode-menu.

Re: text/dns

[Steve Youngs]

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

* Katsumi Yamaoka <yamaoka@jpl.org> writes:

  >>>>>> In <microsoft-free.87y8jeubr1.fsf@youngs.au.com> Steve Youngs wrote:
  >> I've just discovered another problem.  Once `dns-mode' is invoked, I
  >> get a `DNS' menu in every new buffer (there's one in my message buffer
  >> right now).

  > That occurs only in XEmacs 21.4.  

I get the same thing in XEmacs 21.5 too.

  > I have nothing to indicate but found using easy-menu-add instead
  > of easy-menu-add-item helps.  This is what message-mode (which is
  > derived from text-mode as well) does.

[...]

  > -  (easy-menu-add-item nil nil dns-mode-menu))
  > +  (easy-menu-add dns-mode-menu dns-mode-map))

This fixes it for me.
 
  > However, I suspect there is something wrong in XEmacs 21.4 and I
  > don't think the above patch is a right solution.

Yes I agree that there probably is something amiss in XEmacs, but IMO
`easy-menu-add' is better suited for this occasion and I think your
patch is the right thing[tm].

-- 
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
|                   Te audire no possum.                   |
|             Musa sapientum fixa est in aure.             |
|----------------------------------<steve@youngs.au.com>---|

[-- Attachment #2: Type: application/pgp-signature, Size: 256 bytes --]

Re: text/dns

[Katsumi Yamaoka]

>>>>> In <microsoft-free.87r7p6rbog.fsf@youngs.au.com> Steve Youngs wrote:

> * Katsumi Yamaoka <yamaoka@jpl.org> writes:

>> That occurs only in XEmacs 21.4.

> I get the same thing in XEmacs 21.5 too.

Oh, how stupid of me.  I tested it with modified dns-mode.el.
Now I confirmed it.

>> -  (easy-menu-add-item nil nil dns-mode-menu))
>> +  (easy-menu-add dns-mode-menu dns-mode-map))

> This fixes it for me.

>> However, I suspect there is something wrong in XEmacs 21.4 and I
>> don't think the above patch is a right solution.

> Yes I agree that there probably is something amiss in XEmacs, but IMO
> `easy-menu-add' is better suited for this occasion and I think your
> patch is the right thing[tm].

I agree.

Re: text/dns

[Simon Josefsson]

I've incorporated your suggestions, thanks.