Gnus development mailing list
 help / color / mirror / Atom feed
From: Simon Josefsson <simon@josefsson.org>
Subject: Re: citation and flow-filling
Date: 23 May 2001 21:45:06 +0200	[thread overview]
Message-ID: <ilun183j1dp.fsf@barbar.josefsson.org> (raw)
In-Reply-To: <m38zjnx437.fsf@multivac.cwru.edu> (prj@po.cwru.edu's message of "23 May 2001 15:22:30 -0400")

prj@po.cwru.edu (Paul Jarc) writes:

> When flow-filling an article with quoted material, Gnus treats space
> as a non-quote character, even when it is followed by a quote
> character (">") and is preceded by only quote characters.  This is
> what RFC 2646 says it ought to do, but in practice, it breaks.  Gnus
> actually breaks this itself, because when quoting, "> " is prepended
> to each line.  If the line already starts with a quoting character,
> then only ">" should be prepended.

Yes.  Try attached patch.

> I see message-cite-prefix-regexp, but I don't think it's used for
> flow-filling, or citation in replies.  If not, I'd be happy to add
> the code, if someone can point me in the right direction.

I don't think it should be used in flow-filling (it has it's own hard
coded rules to match rfc2646), but the patch below makes use of it
when indenting messages.

> Also, is there an existing function I can add to message-send-hook or
> some such to make my messages format=flowed?

Until emacs support visual cues for soft and hard line breaks, I see
little point of adding support for it in Gnus -- I mean, how would you
know if a paragraph contained soft or hard line breaks when you edit
it?

I do find it quite amazing that emacs doesn't support visual cues for
TAB, soft/hard linebreaks etc though.  I mean, I bet even vi supports
this.  (Lete the flame war begin... :-))

--- message.el.~6.82.~	Wed May 16 20:52:26 2001
+++ message.el	Wed May 23 21:33:16 2001
@@ -523,6 +523,12 @@
   :type 'string
   :group 'message-insertion)
 
+(defcustom message-yank-cited-prefix ">"
+  "*Prefix inserted on cited lines of yanked messages.
+Fix `message-cite-prefix-regexp' if it is set to an abnormal value."
+  :type 'string
+  :group 'message-insertion)
+
 (defcustom message-indentation-spaces 3
   "*Number of spaces to insert at the beginning of each cited line.
 Used by `message-yank-original' via `message-yank-cite'."
@@ -2074,7 +2080,9 @@
       (save-excursion
 	(goto-char start)
 	(while (< (point) (mark t))
-	  (insert message-yank-prefix)
+	  (if (looking-at message-cite-prefix-regexp)
+	      (insert message-yank-cited-prefix)
+	    (insert message-yank-prefix))
 	  (forward-line 1))))
     (goto-char start)))
 



  parent reply	other threads:[~2001-05-23 19:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-23 19:22 Paul Jarc
2001-05-23 19:40 ` Kai Großjohann
     [not found]   ` <ygewv77ikji.fsf@asfast.com>
     [not found]     ` <vaf1ypfrss1.fsf@lucy.cs.uni-dortmund.de>
2001-05-24 11:37       ` Lloyd Zusman
2001-05-24 11:57         ` Lloyd Zusman
2001-05-23 19:45 ` Simon Josefsson [this message]
2001-05-23 23:11   ` Paul Jarc
2001-05-27  9:29     ` Simon Josefsson
2001-05-27 22:20       ` Hal Snyder
2001-05-24  9:47   ` Kai Großjohann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ilun183j1dp.fsf@barbar.josefsson.org \
    --to=simon@josefsson.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).