From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/61042 Path: news.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.gnus.general Subject: Re: message-remove-duplicates and gnus-remove-duplicates Date: Thu, 29 Sep 2005 15:39:36 +0200 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1128001857 16046 80.91.229.2 (29 Sep 2005 13:50:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 29 Sep 2005 13:50:57 +0000 (UTC) Original-X-From: ding-owner+m9574@lists.math.uh.edu Thu Sep 29 15:50:51 2005 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EKylc-0000W3-H4 for ding-account@gmane.org; Thu, 29 Sep 2005 15:48:08 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1EKylQ-0006dy-00; Thu, 29 Sep 2005 08:47:56 -0500 Original-Received: from nas02.math.uh.edu ([129.7.128.40]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1EKydW-0006ds-00 for ding@lists.math.uh.edu; Thu, 29 Sep 2005 08:39:47 -0500 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas02.math.uh.edu with esmtp (Exim 4.52) id 1EKydS-0001DD-CI for ding@lists.math.uh.edu; Thu, 29 Sep 2005 08:39:46 -0500 Original-Received: from 178.230.13.217.in-addr.dgcsystems.net ([217.13.230.178] helo=yxa.extundo.com) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1EKydR-0000PC-00 for ; Thu, 29 Sep 2005 15:39:41 +0200 Original-Received: from latte.josefsson.org (c494102a.s-bi.bostream.se [217.215.27.65]) (authenticated bits=0) by yxa.extundo.com (8.13.4/8.13.4/Debian-3) with ESMTP id j8TDdd1w000804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 29 Sep 2005 15:39:40 +0200 Original-To: ding@gnus.org OpenPGP: id=B565716F; url=http://josefsson.org/key.txt X-Hashcash: 1:21:050929:ding@gnus.org::dWCvabajnDyTEeHg:28n3 In-Reply-To: (Reiner Steib's message of "Wed, 28 Sep 2005 16:25:25 +0200") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Spam-Status: No, score=0.1 required=5.0 tests=FORGED_RCVD_HELO autolearn=failed version=3.0.3 X-Spam-Checker-Version: SpamAssassin 3.0.3 (2005-04-27) on yxa-iv X-Virus-Scanned: ClamAV version 0.84, clamav-milter version 0.84e on yxa.extundo.com X-Virus-Status: Clean X-MIME-Autoconverted: from 8bit to quoted-printable by yxa.extundo.com id j8TDdd1w000804 X-Spam-Score: -2.5 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:61042 Archived-At: Reiner Steib writes: > On Tue, Sep 27 2005, Simon Josefsson committed: > >> 2005-09-27 Arne J=F8rgensen >> >> * message.el (message-remove-duplicates): New function. >> Implementation borrowed from `gnus-remove-duplicates'. > [...] >> +(defun message-remove-duplicates (list) >> + (let (new) >> + (while list >> + (or (member (car list) new) >> + (setq new (cons (car list) new))) >> + (setq list (cdr list))) >> + (nreverse new))) > > Shouldn't we drop (or defalias) `gnus-remove-duplicates' in favor of > `message-remove-duplicates'? (We can safely require `message.el' in > Gnus code but not the other way round.) Sounds good. Let's defalias it, in case external packages use g-r-d. There is also mm-delete-duplicates, I'm not sure how it relates.