Re: Fwd: Patch for a bug in imap-open

[Simon Josefsson <jas@extundo.com>]

Ramkumar R <andyetitmoves@gmail.com> writes:

> Hi!
>
> I had sent a patch to Lars (plz. see details in the conv. below). He
> has asked me to send it to this group for its perusal...so here's the
> patch...
...
>> I encountered an error when opening my inbox over imap with starttls.
>> There is an error thrown up which gets swallowed by a condition-case
>> somewhere higher up and I get an error message and a yes-or-no-p
>> asking me if I want to continue. Traced the problem to imap-open and I
>> have enclosed a patch. I program in lisp, but have no idea about the
>> gnus source. So, it is likely that the solution is wrong or hackish.
>> Works for me though :)
...
> Index: lisp/imap.el
> ===================================================================
> RCS file: /usr/local/cvsroot/gnus/lisp/imap.el,v
> retrieving revision 7.21
> diff -r7.21 imap.el
> 1094,1095c1094,1097
> < 		      (kill-buffer buffer)
> < 		      (rename-buffer buffer)
> ---
>> 		      (let ((bname (buffer-name buffer)))
>> 			(kill-buffer buffer)
>> 			(setq buffer (current-buffer))
>> 			(rename-buffer bname))

There is something wrong with this patch; imap-open should make sure
the returned process is inside the buffer provided in the BUFFER
argument.  Your patch changes this interface, causing all callers of
imap-open to be updated as follows:

> Index: lisp/mail-source.el
> ===================================================================
> RCS file: /usr/local/cvsroot/gnus/lisp/mail-source.el,v
> retrieving revision 7.11
> diff -r7.11 mail-source.el
> 993c993
> <       (if (and (imap-open server port stream authentication buf)
> ---
>>       (if (and (setq buf (imap-open server port stream authentication buf))

Doing that is complicated inside nnimap.el, and I'd rather not change
the API in this way if possible.

Exactly what problem did you see?  Use (setq debug-on-signal t) to
find errors that are swallowed by condition-case.