From: Simon Josefsson <jas@extundo.com>
Cc: ding@gnus.org
Subject: Re: pgg-passphrase-cache-expiry customization patch
Date: Wed, 30 Oct 2002 19:45:11 +0100 [thread overview]
Message-ID: <ilur8e7ahqg.fsf@latte.josefsson.org> (raw)
In-Reply-To: <87znswsdwl.fsf@bigbox.barillari.org> (Joseph Barillari's message of "Wed, 30 Oct 2002 00:18:18 -0500")
Joseph Barillari <jbarilla@princeton.edu> writes:
> Hi.
>
> I've been off the list for a while (actually, I still am, so I'd
> really appreciate it if you'd cc: me with any replies). Perhaps I
> missed the debate on the issue (though I didn't see it in the
> archives): why is pgg-passphrase-cache-expiry hardcoded to 16
> and left with no customization option? One could change it with setq
> in .gnus, but I assume that you'd rather have a defcustom.
Yup.
> The patch I attached replaces the boolean pgg-cache-passphrase with a
> test for the non-zeroness of pgg-passphrase-cache-expiry, and adds a
> corresponding defcustom.
IMHO it is better to keep the current variable names, if for no other
reason that people might have already started using them. I committed
the patch below, please holler if you don't like it.
--- pgg.el.~6.8.~ 2002-10-24 17:24:30.000000000 +0200
+++ pgg.el 2002-10-30 19:40:41.000000000 +0100
@@ -87,7 +87,6 @@
(set-buffer standard-output)
(insert-buffer-substring pgg-errors-buffer)))))
-(defvar pgg-passphrase-cache-expiry 16)
(defvar pgg-passphrase-cache (make-vector 7 0))
(defvar pgg-read-passphrase nil)
--- pgg-def.el.~6.2.~ 2002-10-11 01:35:47.000000000 +0200
+++ pgg-def.el 2002-10-30 19:40:28.000000000 +0100
@@ -63,6 +63,13 @@
:group 'pgg
:type 'boolean)
+(defcustom pgg-passphrase-cache-expiry 16
+ "How many seconds the passphrase is cached.
+Whether the passphrase is cached at all is controlled by
+`pgg-cache-passphrase'."
+ :group 'pgg
+ :type 'integer)
+
(defvar pgg-messages-coding-system nil
"Coding system used when reading from a PGP external process.")
prev parent reply other threads:[~2002-10-30 18:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-30 5:18 Joseph Barillari
2002-10-30 18:45 ` Simon Josefsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ilur8e7ahqg.fsf@latte.josefsson.org \
--to=jas@extundo.com \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).