From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/47486 Path: main.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.gnus.general Subject: Re: pgg-passphrase-cache-expiry customization patch Date: Wed, 30 Oct 2002 19:45:11 +0100 Sender: owner-ding@hpc.uh.edu Message-ID: References: <87znswsdwl.fsf@bigbox.barillari.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1036003928 12019 80.91.224.249 (30 Oct 2002 18:52:08 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 30 Oct 2002 18:52:08 +0000 (UTC) Cc: ding@gnus.org Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 186xrp-0002oU-00 for ; Wed, 30 Oct 2002 19:47:01 +0100 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 186xqg-00059M-00; Wed, 30 Oct 2002 12:45:50 -0600 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Wed, 30 Oct 2002 12:46:34 -0600 (CST) Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id MAA14871 for ; Wed, 30 Oct 2002 12:46:14 -0600 (CST) Original-Received: (qmail 2899 invoked by alias); 30 Oct 2002 18:45:21 -0000 Original-Received: (qmail 2894 invoked from network); 30 Oct 2002 18:45:21 -0000 Original-Received: from 178.230.13.217.in-addr.dgcsystems.net (HELO yxa.extundo.com) (217.13.230.178) by gnus.org with SMTP; 30 Oct 2002 18:45:21 -0000 Original-Received: from latte.josefsson.org (yxa.extundo.com [217.13.230.178]) (authenticated bits=0) by yxa.extundo.com (8.12.6/8.12.6) with ESMTP id g9UIjHFu014426 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Wed, 30 Oct 2002 19:45:18 +0100 Original-To: Joseph Barillari Mail-Copies-To: nobody X-Hashcash: 0:021030:jbarilla@princeton.edu:5c07f6195464fd8d X-Hashcash: 0:021030:ding@gnus.org:e60a09b5c3448ab8 In-Reply-To: <87znswsdwl.fsf@bigbox.barillari.org> (Joseph Barillari's message of "Wed, 30 Oct 2002 00:18:18 -0500") User-Agent: Gnus/5.090008 (Oort Gnus v0.08) Emacs/21.3.50 (i686-pc-linux-gnu) Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:47486 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:47486 Joseph Barillari writes: > Hi. > > I've been off the list for a while (actually, I still am, so I'd > really appreciate it if you'd cc: me with any replies). Perhaps I > missed the debate on the issue (though I didn't see it in the > archives): why is pgg-passphrase-cache-expiry hardcoded to 16 > and left with no customization option? One could change it with setq > in .gnus, but I assume that you'd rather have a defcustom. Yup. > The patch I attached replaces the boolean pgg-cache-passphrase with a > test for the non-zeroness of pgg-passphrase-cache-expiry, and adds a > corresponding defcustom. IMHO it is better to keep the current variable names, if for no other reason that people might have already started using them. I committed the patch below, please holler if you don't like it. --- pgg.el.~6.8.~ 2002-10-24 17:24:30.000000000 +0200 +++ pgg.el 2002-10-30 19:40:41.000000000 +0100 @@ -87,7 +87,6 @@ (set-buffer standard-output) (insert-buffer-substring pgg-errors-buffer))))) -(defvar pgg-passphrase-cache-expiry 16) (defvar pgg-passphrase-cache (make-vector 7 0)) (defvar pgg-read-passphrase nil) --- pgg-def.el.~6.2.~ 2002-10-11 01:35:47.000000000 +0200 +++ pgg-def.el 2002-10-30 19:40:28.000000000 +0100 @@ -63,6 +63,13 @@ :group 'pgg :type 'boolean) +(defcustom pgg-passphrase-cache-expiry 16 + "How many seconds the passphrase is cached. +Whether the passphrase is cached at all is controlled by +`pgg-cache-passphrase'." + :group 'pgg + :type 'integer) + (defvar pgg-messages-coding-system nil "Coding system used when reading from a PGP external process.")