Re: regular and adaptive scoring with nnimap

[Simon Josefsson <jas@extundo.com>]

Ted Zlatanov <tzz@lifelogs.com> writes:

> How does this look, for retrieving an article and searching a group by
> any parameter?
>
> (defun nnimap-db-get-article-contents (article group &optional server)
>   (let ((data))
>     (when (numberp article)
>       (with-current-buffer (nnimap-get-server-buffer server)
> 	(let ((saved (imap-current-mailbox)))
> 	  (with-temp-buffer
> 	    (nnimap-request-article article group server (buffer-name))
> 	    (setq data (buffer-string)))
> 	  (nnimap-possibly-change-group saved server))))
>     data))

Looks good.  You might want to remove the store-and-restore current
mailbox, I don't think it is necessary and on some servers it will be
really slow.

> (defun nnimap-db-get-uids-for-parameter (group parameter subject &optional server)
>   (let ((articles))
>     (when (and (stringp subject) (stringp parameter) (stringp group))
>       (with-current-buffer (nnimap-get-server-buffer server)
> 	(let ((saved (imap-current-mailbox)))
> 	  (nnimap-possibly-change-group group server)
> 	  (setq articles (imap-search (format "HEADER %s \"%s\"" parameter subject)))
> 	  (nnimap-possibly-change-group saved server))))
>     articles))

Looks good, with the same comment as above.

> ;; (nnimap-db-get-uids-for-parameter "ding" "Subject" "spam")
> ;; (nnimap-db-get-uids-for-parameter "ding" "Message-Id" "<ilu4r7k83j5.fsf@latte.josefsson.org>")
>
> I'm assuming two things:
>
> 1) (nnimap-possibly-change-group nil) is harmless
> 2) (nnimap-possibly-change-group nil) returns the current group
>
> Are both true?

n-p-c-g is actually somewhat broken (uidvalidity), so I suggest not
using it.  Instead, either use

      (if (imap-current-mailbox-p group)
	  imap-current-mailbox
	(if (imap-mailbox-select group)
           imap-current-mailbox
         (error "Could not select group: %s" (imap-error-text)))

or something.

> I would use imap exclusively, but nnimap-possibly-change-group and the
> other functions it offers are too useful :)

Maybe the above code should be added as imap-possibly-change-group.  Hm.

> Also, do I need to do
>
> (setq gnus-newsgroup-active (gnus-activate-group group))
>
> before each operation in case the nnimap server is not activated?

You should try to make sure the server is open, yes.  Setting that
variable is probably not the right thing though, I think it is buffer
local to summary buffers. g-a-g calls various hooks and stuff too, so
perhaps it is not perfect to use.