From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/47567 Path: main.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.gnus.general Subject: Re: Cannot open load file: tool-bar Date: Wed, 06 Nov 2002 08:27:21 +0100 Sender: owner-ding@hpc.uh.edu Message-ID: References: <847kfu5w3g.fsf@crybaby.uni-duisburg.de> <84y989mott.fsf@crybaby.uni-duisburg.de> <84iszdqc5h.fsf@crybaby.uni-duisburg.de> <84n0oompug.fsf@crybaby.uni-duisburg.de> <841y60exlw.fsf@crybaby.uni-duisburg.de> <87n0onivy2.fsf@bundalo.shootybangbang.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: main.gmane.org 1036567723 7833 80.91.224.249 (6 Nov 2002 07:28:43 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 6 Nov 2002 07:28:43 +0000 (UTC) Cc: ding@gnus.org Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 189KcD-000227-00 for ; Wed, 06 Nov 2002 08:28:41 +0100 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 189KbW-0000QQ-00; Wed, 06 Nov 2002 01:27:58 -0600 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Wed, 06 Nov 2002 01:28:43 -0600 (CST) Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id BAA09217 for ; Wed, 6 Nov 2002 01:28:20 -0600 (CST) Original-Received: (qmail 4352 invoked by alias); 6 Nov 2002 07:27:29 -0000 Original-Received: (qmail 4347 invoked from network); 6 Nov 2002 07:27:29 -0000 Original-Received: from 178.230.13.217.in-addr.dgcsystems.net (HELO yxa.extundo.com) (217.13.230.178) by gnus.org with SMTP; 6 Nov 2002 07:27:29 -0000 Original-Received: from latte.josefsson.org (yxa.extundo.com [217.13.230.178]) (authenticated bits=0) by yxa.extundo.com (8.12.6/8.12.6) with ESMTP id gA67RLFu028412 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Wed, 6 Nov 2002 08:27:22 +0100 Original-To: John Paul Wallington Mail-Copies-To: nobody X-Hashcash: 0:021106:jpw@shootybangbang.com:b1bb12d2d89b7e8f X-Hashcash: 0:021106:ding@gnus.org:0151f00b2493c865 In-Reply-To: <87n0onivy2.fsf@bundalo.shootybangbang.com> (John Paul Wallington's message of "Tue, 05 Nov 2002 20:49:09 +0000") User-Agent: Gnus/5.090008 (Oort Gnus v0.08) Emacs/21.2.92 (i686-pc-linux-gnu) Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:47567 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:47567 John Paul Wallington writes: > kai.grossjohann@uni-duisburg.de (Kai Großjohann) wrote: > >> Hm. Now that you mention it... See this code: >> >> /---- >> | ;; Emacs 21 tool bar. Should be no-op otherwise. >> | (defun gnus-group-make-tool-bar () >> | (if (and >> | (condition-case nil (require 'tool-bar) (error nil)) >> | (fboundp 'tool-bar-add-item-from-menu) >> \---- >> >> It comes from gnus-group.el. As you can see, it tries to load the >> file, ignoring errors, and if that fails it skips the code that only >> works for Emacs 21. >> >> So, what can we do? > > The (condition-case nil (require 'tool-bar) (error nil)) is unnecessary > because `tool-bar-add-item-from-menu' is autoloaded and therefore > fbound (at least in RC and HEAD, untested in 21.1/2). XEmacs doesn't have tool-bar nor tool-bar-add-item-from-menu.