request for group parameter: posting-charset

request for group parameter: posting-charset

[NAGY Andras]

Variable                           Group Parameter
----------------------------------------------------
gnus-group-charset-alist           charset
gnus-group-ignored-charsets-alist  ignored-charsets
gnus-group-posting-charset-alist   ?

The `?' should be fixed. :-)


András

Re: request for group parameter: posting-charset

[Simon Josefsson]

NAGY Andras <nagya@inf.elte.hu> writes:

> Variable                           Group Parameter
> ----------------------------------------------------
> gnus-group-charset-alist           charset
> gnus-group-ignored-charsets-alist  ignored-charsets
> gnus-group-posting-charset-alist   ?
>
> The `?' should be fixed. :-)

Does this work?

--- gnus-msg.el.~6.94.~	Fri Jun 14 17:55:20 2002
+++ gnus-msg.el	Sat Jun 15 12:10:04 2002
@@ -160,11 +160,18 @@
 		 (const all :tag "Any")
 		 (string :tag "Regexp")))
 
-(defcustom gnus-group-posting-charset-alist
+(gnus-define-group-parameter
+ posting-charset-alist
+ :type list
+ :function-document
+ "Return the permitted unencoded charsets for posting of GROUP."
+ :variable gnus-group-posting-charset-alist
+ :variable-default
   '(("^\\(no\\|fr\\)\\.[^,]*\\(,[ \t\n]*\\(no\\|fr\\)\\.[^,]*\\)*$" iso-8859-1 (iso-8859-1))
     ("^\\(fido7\\|relcom\\)\\.[^,]*\\(,[ \t\n]*\\(fido7\\|relcom\\)\\.[^,]*\\)*$" koi8-r (koi8-r))
     (message-this-is-mail nil nil)
     (message-this-is-news nil t))
+ :variable-document
   "Alist of regexps and permitted unencoded charsets for posting.
 Each element of the alist has the form (TEST HEADER BODY-LIST), where
 TEST is either a regular expression matching the newsgroup header or a
@@ -177,7 +184,9 @@
 
 Note that any value other than nil for HEADER infringes some RFCs, so
 use this option with care."
-  :type '(repeat (list :tag "Permitted unencoded charsets"
+ :variable-group gnus-charset
+ :variable-type
+ '(repeat (list :tag "Permitted unencoded charsets"
 		  (choice :tag "Where"
 		   (regexp :tag "Group")
 		   (const :tag "Mail message" :value message-this-is-mail)
@@ -190,7 +199,11 @@
 			  (const :tag "None" :value nil)
 			  (repeat :tag "Charsets"
 				  (symbol :tag "Charset")))))
-  :group 'gnus-charset)
+ :parameter-type '(choice :tag "Permitted unencoded charsets"
+			  :value nil
+			  (repeat (symbol)))
+ :parameter-document       "\
+List of charsets that are permitted to be unencoded.")
 
 (defcustom gnus-debug-files
   '("gnus.el" "gnus-sum.el" "gnus-group.el"

Re: request for group parameter: posting-charset

[NAGY Andras]

On Sat, 15 Jun 2002, at 12:11, Simon Josefsson <jas@extundo.com> wrote:

>> Variable                           Group Parameter
>> ----------------------------------------------------
>> gnus-group-charset-alist           charset
>> gnus-group-ignored-charsets-alist  ignored-charsets
>> gnus-group-posting-charset-alist   ?
>>
>> The `?' should be fixed. :-)
>
> Does this work?

Firstly, I believe the group paramter should be called just
posting-charset, as the value of the parameter is not an alist, only
the global variable gnus-group-posting-charset-alist is.

Furthermore, I think the code now referring to
gnus-group-posting-charset-alist should be changed as well to use
(gnus-group-find-parameter 'posting-charset) or similar instead of
accessing the global alist directly.  (AFAIK, find-parameter considers
the global alist as well, so there is no need to check both.  But I'm
not sure.)

Perhaps because of this, it does not work for me.


Andras