Re: Hashcash-generation/check for IDN-domains

[Simon Josefsson <jas@extundo.com>]

asjo@koldfront.dk (Adam Sjøgren) writes:

>>> The checking does seem a little too fragile though, in that spam-split
>>> breaks just because hashcash.el can't understand a Hashcash-header
>>> (i.e. the mail-check-payment should just return false when the header
>>> is not understandable, right? Instead of the error that makes nnmail
>>> think that my fancy-split configuration is invalid).
>
>> What error is that?  Does it say "Unknown hashcash format version"?
>> Perhaps the call to hashcash.el should be made in a condition-case.
>
> That is where it failed, in hashcash-version, when I got the message
> about error in nnmail-split-methods.
>
> It's easy to recreate, just put the email in a buffer and run
> mail-check-payment: "Unknown hashcash format version".

Can you test this patch?

2005-09-29  Simon Josefsson  <jas@extundo.com>

	* spam.el: Load hashcash when compiling, to avoid warnings.  Don't
	autoload mail-check-payment.
	(spam-check-hashcash): Define unconditionally, since hashcash.el
	is part of Gnus now.  Ignore errors from payment checking.

--- spam.el	27 Sep 2005 16:46:44 +0200	7.75
+++ spam.el	29 Sep 2005 15:34:25 +0200	
@@ -42,6 +42,7 @@
 
 (eval-when-compile (require 'cl))
 (eval-when-compile (require 'spam-report))
+(eval-when-compile (require 'hashcash))
 
 (require 'gnus-sum)
 
@@ -2023,18 +2024,10 @@
 
 ;;{{{ Hashcash.
 
-(eval-when-compile
-  (autoload 'mail-check-payment "hashcash"))
-
-(condition-case nil
-    (progn
-      (require 'hashcash)
-
       (defun spam-check-hashcash ()
 	"Check the headers for hashcash payments."
-	(mail-check-payment)))	 ;mail-check-payment returns a boolean
+  (ignore-errors (mail-check-payment)))	 ;mail-check-payment returns a boolean
 
-  (file-error))
 ;;}}}
 
 ;;{{{ BBDB