From: Simon Josefsson <jas@pdc.kth.se>
Cc: ding@gnus.org
Subject: Re: denying nnimap server causes nnimap-close-group to crash
Date: 30 May 2000 14:40:15 +0200 [thread overview]
Message-ID: <iluwvkcfbyo.fsf@badis.pdc.kth.se> (raw)
In-Reply-To: Steinar Bang's message of "26 May 2000 15:54:02 +0200"
Steinar Bang <sb@metis.no> writes:
> However if I go to the server buffer, and press D on these servers,
> and then go back to *Group* and press
> g
> I end up with the following stack trace:
>
> Signaling: (wrong-type-argument stringp nil)
> set-buffer(nil)
> (save-current-buffer (set-buffer nnimap-server-buffer) (when (and ... ...) (case nnimap-expunge-on-close ... ... ...) (not imap-current-mailbox)))
> )
> (with-current-buffer nnimap-server-buffer (when (and ... ...) (case nnimap-expunge-on-close ... ... ...) (not imap-current-mailbox)))
> )
> nnimap-close-group("INBOX" "somemachine.somecompany.no")
> gnus-get-unread-articles(2)
> gnus-group-get-new-news(2)
> call-interactively(gnus-group-get-new-news)
>
> Anyone's got an idea what is wrong?
Looks like `gnus-get-unread-articles' doesn't care if a server is
denied or not. Could you try this patch?
2000-05-30 Simon Josefsson <jas@pdc.kth.se>
* gnus-start.el (gnus-get-unread-articles): If
`gnus-activate-group' and/or `gnus-check-server' return nil, don't
try to do anything on that server.
Index: gnus-start.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-start.el,v
retrieving revision 5.54
diff -w -u -u -w -r5.54 gnus-start.el
--- gnus-start.el 2000/05/23 08:09:24 5.54
+++ gnus-start.el 2000/05/29 12:00:19
@@ -1523,8 +1523,8 @@
(setq method (gnus-server-get-method nil method)))))
(not (gnus-secondary-method-p method)))
;; These groups are foreign. Check the level.
- (when (<= (gnus-info-level info) foreign-level)
- (setq active (gnus-activate-group group 'scan))
+ (when (and (<= (gnus-info-level info) foreign-level)
+ (setq active (gnus-activate-group group 'scan)))
;; Let the Gnus agent save the active file.
(when (and gnus-agent gnus-plugged active)
(gnus-agent-save-group-info
@@ -1565,7 +1565,8 @@
(setq active (gnus-activate-group group))
(setq active (gnus-activate-group group 'scan))
(push method scanned-methods))
- (inline (gnus-close-group group))))))
+ (when active
+ (gnus-close-group group))))))
;; Get the number of unread articles in the group.
(cond
@@ -1587,7 +1588,7 @@
(let* ((mg (pop retrievegroups))
(method (or (car mg) gnus-select-method))
(groups (cdr mg)))
- (gnus-check-server method)
+ (when (gnus-check-server method)
;; Request that the backend scan its incoming messages.
(when (gnus-check-backend-function 'request-scan (car method))
(gnus-request-scan nil method))
@@ -1603,7 +1604,7 @@
;; The group couldn't be reached, so we nix out the number of
;; unread articles and stuff.
(gnus-set-active group nil)
- (setcar (gnus-gethash group gnus-newsrc-hashtb) t))))))
+ (setcar (gnus-gethash group gnus-newsrc-hashtb) t)))))))
(gnus-message 5 "Checking new news...done")))
next prev parent reply other threads:[~2000-05-30 12:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-05-26 13:54 Steinar Bang
2000-05-26 16:13 ` Steinar Bang
2000-05-30 12:40 ` Simon Josefsson [this message]
2000-05-31 16:22 ` Steinar Bang
2000-05-31 18:42 ` Simon Josefsson
2000-06-01 11:10 ` Steinar Bang
2000-06-02 13:48 ` Christoph Rohland
2000-06-05 16:01 ` Toby Speight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=iluwvkcfbyo.fsf@badis.pdc.kth.se \
--to=jas@pdc.kth.se \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).