From: Simon Josefsson <jas@pdc.kth.se>
Cc: ding@gnus.org
Subject: Re: gnus-group-get-new-news broken again
Date: 05 Dec 1999 16:16:19 +0100 [thread overview]
Message-ID: <iluwvqto1to.fsf@badis.pdc.kth.se> (raw)
In-Reply-To: Shenghuo ZHU's message of "04 Dec 1999 23:20:44 -0500"
Shenghuo ZHU <zsh@cs.rochester.edu> writes:
> I think the patch speed up most mail sources correctly except
> directory, since there is a hack code in nnmail-get-new-mail
> (nnmail.el:1426), which only fetch the contents of a single group's
> spool file. With the patch, `2 g' fetching for the first group
> inhibits fetching from other spool files. For those users who do not
> use directory as a mail source, this patch would not be a problem.
Ouch. This patch add the hack to the scanning part too, but this is
getting quite messy. It wouldn't work if `mail-sources' can be a group
parameter (or non-global in any way), but I'm not sure if it can be,
so... Whatdoyouthink, should I apply this or remove my earlier
speed-up patch?
Index: gnus-start.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-start.el,v
retrieving revision 5.46
diff -w -u -u -w -r5.46 gnus-start.el
--- gnus-start.el 1999/12/05 03:00:20 5.46
+++ gnus-start.el 1999/12/05 15:08:44
@@ -1550,7 +1550,15 @@
(setcdr (assoc method retrievegroups)
(cons group (cdr (assoc method retrievegroups))))
(push (list method group) retrievegroups))
- (if (member method scanned-methods)
+ ;; hack: `nnmail-get-new-mail' changes the mail-source depending
+ ;; on the group, so we must perform a scan for every group
+ ;; if the users has any directory mail sources.
+ (if (and (null (assq 'directory
+ (or mail-sources
+ (if (listp nnmail-spool-file)
+ nnmail-spool-file
+ (list nnmail-spool-file)))))
+ (member method scanned-methods))
(setq active (gnus-activate-group group))
(setq active (gnus-activate-group group 'scan))
(push method scanned-methods))
next prev parent reply other threads:[~1999-12-05 15:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-12-04 14:24 Bruce Stephens
1999-12-04 16:52 ` Michael Harnois
1999-12-04 17:17 ` Shenghuo ZHU
1999-12-04 17:46 ` Michael Harnois
1999-12-05 0:43 ` Simon Josefsson
1999-12-05 4:20 ` Shenghuo ZHU
1999-12-05 15:16 ` Simon Josefsson [this message]
1999-12-05 16:24 ` Shenghuo ZHU
1999-12-05 16:53 ` Michael Harnois
1999-12-05 17:01 ` Bruce Stephens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=iluwvqto1to.fsf@badis.pdc.kth.se \
--to=jas@pdc.kth.se \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).