From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/27725 Path: main.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.gnus.general Subject: Re: gnus-group-get-new-news broken again Date: 05 Dec 1999 16:16:19 +0100 Sender: owner-ding@hpc.uh.edu Message-ID: References: <87d7smpywj.fsf@cenderis.demon.co.uk> <87g0xilkcj.fsf@mharnois.workgroup.net> <2niu2evx0j.fsf@tiger.jia.vnet> NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1035164699 26026 80.91.224.250 (21 Oct 2002 01:44:59 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 01:44:59 +0000 (UTC) Cc: ding@gnus.org Return-Path: Original-Received: from bart.math.uh.edu (bart.math.uh.edu [129.7.128.48]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id KAA26002 for ; Sun, 5 Dec 1999 10:17:41 -0500 (EST) Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5]) by bart.math.uh.edu (8.9.1/8.9.1) with ESMTP id JAB13187; Sun, 5 Dec 1999 09:16:54 -0600 (CST) Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Sun, 05 Dec 1999 09:17:03 -0600 (CST) Original-Received: from sclp3.sclp.com (root@sclp3.sclp.com [204.252.123.139]) by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id JAA23919 for ; Sun, 5 Dec 1999 09:16:54 -0600 (CST) Original-Received: from badis.pdc.kth.se (root@badis.pdc.kth.se [130.237.221.45]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id KAA25995 for ; Sun, 5 Dec 1999 10:16:28 -0500 (EST) Original-Received: (from jas@localhost) by badis.pdc.kth.se (8.9.3/8.9.3) id QAA16976; Sun, 5 Dec 1999 16:16:21 +0100 X-Authentication-Warning: badis.pdc.kth.se: jas set sender to jas@pdc.kth.se using -f Original-To: Shenghuo ZHU In-Reply-To: Shenghuo ZHU's message of "04 Dec 1999 23:20:44 -0500" Original-Lines: 39 User-Agent: Gnus/5.0803 (Gnus v5.8.3) Emacs/20.3 Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:27725 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:27725 Shenghuo ZHU writes: > I think the patch speed up most mail sources correctly except > directory, since there is a hack code in nnmail-get-new-mail > (nnmail.el:1426), which only fetch the contents of a single group's > spool file. With the patch, `2 g' fetching for the first group > inhibits fetching from other spool files. For those users who do not > use directory as a mail source, this patch would not be a problem. Ouch. This patch add the hack to the scanning part too, but this is getting quite messy. It wouldn't work if `mail-sources' can be a group parameter (or non-global in any way), but I'm not sure if it can be, so... Whatdoyouthink, should I apply this or remove my earlier speed-up patch? Index: gnus-start.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/gnus-start.el,v retrieving revision 5.46 diff -w -u -u -w -r5.46 gnus-start.el --- gnus-start.el 1999/12/05 03:00:20 5.46 +++ gnus-start.el 1999/12/05 15:08:44 @@ -1550,7 +1550,15 @@ (setcdr (assoc method retrievegroups) (cons group (cdr (assoc method retrievegroups)))) (push (list method group) retrievegroups)) - (if (member method scanned-methods) + ;; hack: `nnmail-get-new-mail' changes the mail-source depending + ;; on the group, so we must perform a scan for every group + ;; if the users has any directory mail sources. + (if (and (null (assq 'directory + (or mail-sources + (if (listp nnmail-spool-file) + nnmail-spool-file + (list nnmail-spool-file))))) + (member method scanned-methods)) (setq active (gnus-activate-group group)) (setq active (gnus-activate-group group 'scan)) (push method scanned-methods))