From: Andreas Schwab <schwab@suse.de>
To: ding@gnus.org
Subject: Fix scoring on extra headers
Date: Wed, 04 Feb 2009 22:43:20 +0100 [thread overview]
Message-ID: <jezlh1swsn.fsf@sykes.suse.de> (raw)
This fixes scoring on extra headers. The regexp matching the printed
representation does not correctly handle embedded quotes in the value.
Andreas.
2009-02-04 Andreas Schwab <schwab@suse.de>
* gnus-score.el (gnus-score-string): Fix regex for matching extra
headers and regexp-quote the match if necessary.
--- gnus-score.el 04 Feb 2009 15:36:10 +0100 7.42
+++ gnus-score.el 04 Feb 2009 15:38:08 +0100
@@ -2055,8 +2055,11 @@ score in `gnus-newsgroup-scored' by SCOR
;; Evil hackery to make match usable in non-standard headers.
(when extra
- (setq match (concat "[ (](" extra " \\. \"[^)]*"
- match "[^\"]*\")[ )]")
+ (setq match (concat "[ (](" extra " \\. \"\\([^\"]*\\\\\"\\)*[^\"]*"
+ (if (eq search-func 're-search-forward)
+ match
+ (regexp-quote match))
+ "\\([^\"]*\\\\\"\\)*[^\"]*\")[ )]")
search-func 're-search-forward)) ; XXX danger?!?
(cond
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next reply other threads:[~2009-02-04 21:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 21:43 Andreas Schwab [this message]
2010-08-29 22:42 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jezlh1swsn.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).