* Fix scoring on extra headers
@ 2009-02-04 21:43 Andreas Schwab
2010-08-29 22:42 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schwab @ 2009-02-04 21:43 UTC (permalink / raw)
To: ding
This fixes scoring on extra headers. The regexp matching the printed
representation does not correctly handle embedded quotes in the value.
Andreas.
2009-02-04 Andreas Schwab <schwab@suse.de>
* gnus-score.el (gnus-score-string): Fix regex for matching extra
headers and regexp-quote the match if necessary.
--- gnus-score.el 04 Feb 2009 15:36:10 +0100 7.42
+++ gnus-score.el 04 Feb 2009 15:38:08 +0100
@@ -2055,8 +2055,11 @@ score in `gnus-newsgroup-scored' by SCOR
;; Evil hackery to make match usable in non-standard headers.
(when extra
- (setq match (concat "[ (](" extra " \\. \"[^)]*"
- match "[^\"]*\")[ )]")
+ (setq match (concat "[ (](" extra " \\. \"\\([^\"]*\\\\\"\\)*[^\"]*"
+ (if (eq search-func 're-search-forward)
+ match
+ (regexp-quote match))
+ "\\([^\"]*\\\\\"\\)*[^\"]*\")[ )]")
search-func 're-search-forward)) ; XXX danger?!?
(cond
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Fix scoring on extra headers
2009-02-04 21:43 Fix scoring on extra headers Andreas Schwab
@ 2010-08-29 22:42 ` Lars Magne Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-08-29 22:42 UTC (permalink / raw)
To: ding
Andreas Schwab <schwab@suse.de> writes:
> 2009-02-04 Andreas Schwab <schwab@suse.de>
>
> * gnus-score.el (gnus-score-string): Fix regex for matching extra
> headers and regexp-quote the match if necessary.
Ok; applied.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-29 22:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-04 21:43 Fix scoring on extra headers Andreas Schwab
2010-08-29 22:42 ` Lars Magne Ingebrigtsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).